Skip to content

Remove stale no-inline-graphql allowlist entries#8116

Open
isaacroldan wants to merge 1 commit into
partners-cleanup/06-drop-vestigial-account-infofrom
partners-cleanup/07-prune-stale-graphql-allowlist
Open

Remove stale no-inline-graphql allowlist entries#8116
isaacroldan wants to merge 1 commit into
partners-cleanup/06-drop-vestigial-account-infofrom
partners-cleanup/07-prune-stale-graphql-allowlist

Conversation

@isaacroldan

@isaacroldan isaacroldan commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Independent janitorial cleanup, stacked on the PartnersClient cleanup series (#8109#8111#8115).

WHY are these changes introduced?

The no-inline-graphql eslint rule keeps a knownFailures allowlist mapping file paths → content hashes (grandfathered inline-GraphQL exceptions). 17 of its 24 entries point at files that no longer exist — leftovers from earlier app-management and GraphQL refactors (and this cleanup stack). They're dead config: an allowlist entry keyed to a missing file is never consulted by the rule.

WHAT is this pull request doing?

Remove the 17 stale entries, keeping the 7 whose files still exist. One file changed (packages/eslint-plugin-cli/rules/no-inline-graphql.js), −34 lines. No change to lint behavior.

How to test your changes?

pnpm nx lint app passes (the rule's main consumer), and each of the 7 remaining entries corresponds to a file that still exists.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

17 of the knownFailures entries in the no-inline-graphql eslint rule point at files that no longer exist (deleted in earlier app-management and GraphQL refactors, and this cleanup stack). An allowlist entry keyed to a missing file is never consulted by the rule, so removing them is pure dead-config cleanup with no change to lint behavior. The 7 entries for files that still exist are kept.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 16, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/api/partners.d.ts
@@ -1,7 +1,5 @@
 import { GraphQLVariables, GraphQLResponse, CacheOptions, UnauthorizedHandler } from './graphql.js';
 import { RequestModeInput } from '../http.js';
-import { Variables } from 'graphql-request';
-import { TypedDocumentNode } from '@graphql-typed-document-node/core';
 /**
  * Executes a GraphQL query against the Partners API.
  *
@@ -14,21 +12,6 @@ import { TypedDocumentNode } from '@graphql-typed-document-node/core';
  * @returns The response of the query of generic type <T>.
  */
 export declare function partnersRequest<T>(query: string, token: string, variables?: GraphQLVariables, cacheOptions?: CacheOptions, preferredBehaviour?: RequestModeInput, unauthorizedHandler?: UnauthorizedHandler): Promise<T>;
-export declare const generateFetchAppLogUrl: (cursor?: string, filters?: {
-    status?: string;
-    source?: string;
-}) => Promise<string>;
-/**
- * Executes a GraphQL query against the Partners API. Uses typed documents.
- *
- * @param query - GraphQL query to execute.
- * @param token - Partners token.
- * @param variables - GraphQL variables to pass to the query.
- * @param preferredBehaviour - Preferred behaviour for the request.
- * @param unauthorizedHandler - Optional handler for unauthorized requests.
- * @returns The response of the query of generic type <TResult>.
- */
-export declare function partnersRequestDoc<TResult, TVariables extends Variables>(query: TypedDocumentNode<TResult, TVariables>, token: string, variables?: TVariables, preferredBehaviour?: RequestModeInput, unauthorizedHandler?: UnauthorizedHandler): Promise<TResult>;
 /**
  * Sets the next deprecation date from [GraphQL response extensions](https://www.apollographql.com/docs/resources/graphql-glossary/#extensions)
  * if  objects contain a  (ISO 8601-formatted string).

@isaacroldan
isaacroldan marked this pull request as ready for review July 16, 2026 16:47
@isaacroldan
isaacroldan requested a review from a team as a code owner July 16, 2026 16:47

Copy link
Copy Markdown
Contributor Author

/snapit

@github-actions

Copy link
Copy Markdown
Contributor

🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260717124242

Caution

After installing, validate the version by running shopify version in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant