Remove stale no-inline-graphql allowlist entries#8116
Conversation
17 of the knownFailures entries in the no-inline-graphql eslint rule point at files that no longer exist (deleted in earlier app-management and GraphQL refactors, and this cleanup stack). An allowlist entry keyed to a missing file is never consulted by the rule, so removing them is pure dead-config cleanup with no change to lint behavior. The 7 entries for files that still exist are kept. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/api/partners.d.ts@@ -1,7 +1,5 @@
import { GraphQLVariables, GraphQLResponse, CacheOptions, UnauthorizedHandler } from './graphql.js';
import { RequestModeInput } from '../http.js';
-import { Variables } from 'graphql-request';
-import { TypedDocumentNode } from '@graphql-typed-document-node/core';
/**
* Executes a GraphQL query against the Partners API.
*
@@ -14,21 +12,6 @@ import { TypedDocumentNode } from '@graphql-typed-document-node/core';
* @returns The response of the query of generic type <T>.
*/
export declare function partnersRequest<T>(query: string, token: string, variables?: GraphQLVariables, cacheOptions?: CacheOptions, preferredBehaviour?: RequestModeInput, unauthorizedHandler?: UnauthorizedHandler): Promise<T>;
-export declare const generateFetchAppLogUrl: (cursor?: string, filters?: {
- status?: string;
- source?: string;
-}) => Promise<string>;
-/**
- * Executes a GraphQL query against the Partners API. Uses typed documents.
- *
- * @param query - GraphQL query to execute.
- * @param token - Partners token.
- * @param variables - GraphQL variables to pass to the query.
- * @param preferredBehaviour - Preferred behaviour for the request.
- * @param unauthorizedHandler - Optional handler for unauthorized requests.
- * @returns The response of the query of generic type <TResult>.
- */
-export declare function partnersRequestDoc<TResult, TVariables extends Variables>(query: TypedDocumentNode<TResult, TVariables>, token: string, variables?: TVariables, preferredBehaviour?: RequestModeInput, unauthorizedHandler?: UnauthorizedHandler): Promise<TResult>;
/**
* Sets the next deprecation date from [GraphQL response extensions](https://www.apollographql.com/docs/resources/graphql-glossary/#extensions)
* if objects contain a (ISO 8601-formatted string).
|
|
/snapit |
|
🫰✨ Thanks @isaacroldan! Your snapshot has been published to npm. Test the snapshot by installing your package globally: pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260717124242Caution After installing, validate the version by running |

WHY are these changes introduced?
The
no-inline-graphqleslint rule keeps aknownFailuresallowlist mapping file paths → content hashes (grandfathered inline-GraphQL exceptions). 17 of its 24 entries point at files that no longer exist — leftovers from earlier app-management and GraphQL refactors (and this cleanup stack). They're dead config: an allowlist entry keyed to a missing file is never consulted by the rule.WHAT is this pull request doing?
Remove the 17 stale entries, keeping the 7 whose files still exist. One file changed (
packages/eslint-plugin-cli/rules/no-inline-graphql.js), −34 lines. No change to lint behavior.How to test your changes?
pnpm nx lint apppasses (the rule's main consumer), and each of the 7 remaining entries corresponds to a file that still exists.Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset add