Skip to content

[Tests] Add unit tests for showMultipleCLIWarningIfNeeded#8119

Merged
gonzaloriestra merged 1 commit into
mainfrom
tests-multiple-installation-warning-17820496270967834501
Jul 17, 2026
Merged

[Tests] Add unit tests for showMultipleCLIWarningIfNeeded#8119
gonzaloriestra merged 1 commit into
mainfrom
tests-multiple-installation-warning-17820496270967834501

Conversation

@gonzaloriestra

@gonzaloriestra gonzaloriestra commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

This PR introduces comprehensive unit testing for showMultipleCLIWarningIfNeeded in @shopify/cli-kit package to improve coverage and safeguard against regressions, adhering to .agents/automated-tasks/tests.md.

WHAT is this pull request doing?

We added tests covering:

  • Early-exit when @shopify/cli dependency is missing from the passed dependencies.
  • Early-exit when JSON output is enabled.
  • Early-exit when global CLI version cannot be fetched.
  • Early-exit when local CLI version cannot be fetched in global process.
  • Renders info warning with local dependency message when process is not global.
  • Renders info warning with global installation message when process is global.
  • Uses rate-limiting check runAtMinimumInterval correctly.

How to test your changes?

CI

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

PR created automatically by Jules for task 17820496270967834501 started by @gonzaloriestra

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 17, 2026
@gonzaloriestra gonzaloriestra added the Jules Created by Jules label Jul 17, 2026
@gonzaloriestra
gonzaloriestra marked this pull request as ready for review July 17, 2026 08:46
@gonzaloriestra
gonzaloriestra requested a review from a team as a code owner July 17, 2026 08:46

gonzaloriestra commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Jul 17, 10:13 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jul 17, 10:13 AM UTC: @gonzaloriestra added this pull request to the GitHub merge queue with Graphite.

@gonzaloriestra
gonzaloriestra added this pull request to the merge queue Jul 17, 2026
Merged via the queue into main with commit a42f707 Jul 17, 2026
31 checks passed
@gonzaloriestra
gonzaloriestra deleted the tests-multiple-installation-warning-17820496270967834501 branch July 17, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Jules Created by Jules no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants