Clean E2E resources across run attempts#8121
Merged
Merged
Conversation
Assisted-By: devx/4ec3ab45-e67f-4f3d-b737-d67c3faad55d
isaacroldan
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
No linked issue.
Current PR E2E cleanup only searches for resources with the exact
GITHUB_RUN_ID+GITHUB_RUN_ATTEMPTsegment. If an earlier attempt creates E2E apps or dev stores and is cancelled or fails before cleanup completes, a later rerun searches for a different attempt suffix and misses those leftovers.WHAT is this pull request doing?
Updates the PR workflow cleanup pattern to use only the run id segment (
r${RUN_TOKEN}) for both app and store cleanup. E2E resource names still include the attempt suffix, but cleanup now covers all attempts from the same GitHub run.How to test your changes?
gt diff --check.github/workflows/tests-pr.ymlwith Ruby YAML loader.Expected behavior in CI: cleanup for a rerun of the same workflow run can delete resources created by prior attempts because their names share the same
r<run-id>prefix.Post-release steps
None.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addThis is CI-only workflow maintenance, so no changeset is needed.