Skip to content

Clean E2E resources across run attempts#8121

Merged
alfonso-noriega merged 1 commit into
mainfrom
fonso/e2e-cleanup-run-pattern
Jul 17, 2026
Merged

Clean E2E resources across run attempts#8121
alfonso-noriega merged 1 commit into
mainfrom
fonso/e2e-cleanup-run-pattern

Conversation

@alfonso-noriega

@alfonso-noriega alfonso-noriega commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

No linked issue.

Current PR E2E cleanup only searches for resources with the exact GITHUB_RUN_ID + GITHUB_RUN_ATTEMPT segment. If an earlier attempt creates E2E apps or dev stores and is cancelled or fails before cleanup completes, a later rerun searches for a different attempt suffix and misses those leftovers.

WHAT is this pull request doing?

Updates the PR workflow cleanup pattern to use only the run id segment (r${RUN_TOKEN}) for both app and store cleanup. E2E resource names still include the attempt suffix, but cleanup now covers all attempts from the same GitHub run.

How to test your changes?

  • gt diff --check
  • Parsed .github/workflows/tests-pr.yml with Ruby YAML loader.

Expected behavior in CI: cleanup for a rerun of the same workflow run can delete resources created by prior attempts because their names share the same r<run-id> prefix.

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

This is CI-only workflow maintenance, so no changeset is needed.

Assisted-By: devx/4ec3ab45-e67f-4f3d-b737-d67c3faad55d
@alfonso-noriega
alfonso-noriega requested a review from a team as a code owner July 17, 2026 10:28

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 17, 2026
@alfonso-noriega
alfonso-noriega added this pull request to the merge queue Jul 17, 2026
Merged via the queue into main with commit 9ab434b Jul 17, 2026
30 checks passed
@alfonso-noriega
alfonso-noriega deleted the fonso/e2e-cleanup-run-pattern branch July 17, 2026 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants