Skip to content

Run E2E cleanup phases independently - #8122

Merged
alfonso-noriega merged 1 commit into
mainfrom
fonso/e2e-cleanup-independent-steps
Jul 17, 2026
Merged

Run E2E cleanup phases independently#8122
alfonso-noriega merged 1 commit into
mainfrom
fonso/e2e-cleanup-independent-steps

Conversation

@alfonso-noriega

@alfonso-noriega alfonso-noriega commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

No linked issue.

The PR E2E cleanup job has separate app and store cleanup phases, but a failure in auth priming or app cleanup can prevent later cleanup steps from running. That leaves stores behind even though the store cleanup script can independently uninstall apps from stores before deleting them.

WHAT is this pull request doing?

Makes cleanup phases more independent in the PR workflow:

  • Allows cleanup auth priming to fail without stopping the job.
  • Runs app cleanup with if: ${{ always() }} and continue-on-error: true.
  • Runs store cleanup with if: ${{ always() }} and continue-on-error: true.

This keeps each cleanup phase best-effort so one failed phase does not block the next phase.

How to test your changes?

  • gt diff --check
  • Parsed .github/workflows/tests-pr.yml with Ruby YAML loader.

Expected behavior in CI: store cleanup still runs even when cleanup auth priming or app cleanup reports a failure.

Post-release steps

None.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

This is CI-only workflow maintenance, so no changeset is needed.

Assisted-By: devx/4ec3ab45-e67f-4f3d-b737-d67c3faad55d
@alfonso-noriega
alfonso-noriega requested a review from a team as a code owner July 17, 2026 10:28

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jul 17, 2026
@alfonso-noriega
alfonso-noriega added this pull request to the merge queue Jul 17, 2026
Merged via the queue into main with commit 7f41b79 Jul 17, 2026
30 checks passed
@alfonso-noriega
alfonso-noriega deleted the fonso/e2e-cleanup-independent-steps branch July 17, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants