Run E2E cleanup phases independently - #8122
Merged
Merged
Conversation
Assisted-By: devx/4ec3ab45-e67f-4f3d-b737-d67c3faad55d
isaacroldan
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

WHY are these changes introduced?
No linked issue.
The PR E2E cleanup job has separate app and store cleanup phases, but a failure in auth priming or app cleanup can prevent later cleanup steps from running. That leaves stores behind even though the store cleanup script can independently uninstall apps from stores before deleting them.
WHAT is this pull request doing?
Makes cleanup phases more independent in the PR workflow:
if: ${{ always() }}andcontinue-on-error: true.if: ${{ always() }}andcontinue-on-error: true.This keeps each cleanup phase best-effort so one failed phase does not block the next phase.
How to test your changes?
gt diff --check.github/workflows/tests-pr.ymlwith Ruby YAML loader.Expected behavior in CI: store cleanup still runs even when cleanup auth priming or app cleanup reports a failure.
Post-release steps
None.
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addThis is CI-only workflow maintenance, so no changeset is needed.