[Security] Harden ExtensionServerClient random identifier generation#8127
[Security] Harden ExtensionServerClient random identifier generation#8127gonzaloriestra wants to merge 1 commit into
Conversation
Use globalThis.crypto.randomUUID when available to leverage a CSPRNG, fallback to Math.random otherwise.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
Hardens the random identifier generation in ExtensionServerClient by utilizing a cryptographically secure pseudo-random number generator (CSPRNG).
WHAT is this pull request doing?
Replaces the insecure
Math.random()call used to generatethis.idinExtensionServerClientwith a newgenerateRandomIdutility. This utility leveragesglobalThis.crypto.randomUUIDwhere available to ensure unpredictability and falls back to a pseudo-random math string in non-secure or older environments.How to test your changes?
CI
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 1037256159771227403 started by @gonzaloriestra