[Refactor] Use early returns in commonParentDirectory#8128
[Refactor] Use early returns in commonParentDirectory#8128gonzaloriestra wants to merge 1 commit into
Conversation
Replace a ternary operator return with a cleaner early-return pattern if there are one or fewer common components, simplifying readability.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
WHY are these changes introduced?
The ternary operator in
commonParentDirectorycan be made more readable and cleaner by adopting an early-return style.WHAT is this pull request doing?
Refactors the return statement of
commonParentDirectoryinpackages/cli-kit/src/public/node/path.tsto return/early ifi <= 1, then join and return the common components.How to test your changes?
CI
Post-release steps
Checklist
patchfor bug fixes ·minorfor new features ·majorfor breaking changes) and added a changeset withpnpm changeset addPR created automatically by Jules for task 16923425015846468447 started by @gonzaloriestra