GHA: Check for category existence on the main component - #3136
Merged
Conversation
|
Duplicate profile check: Warning - duplicate profiles detected. |
hcarter-775
requested review from
NoahCornell,
aleclorimer,
cjswedes,
ctowns and
tpmanley
July 22, 2026 18:22
|
Invitation URL: |
Test Results 73 files 540 suites 0s ⏱️ Results for commit 84e1a52. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against 761f223 |
hcarter-775
force-pushed
the
add/category-existence-check
branch
2 times, most recently
from
July 22, 2026 18:24
286769e to
9f3bc43
Compare
cjswedes
reviewed
Jul 27, 2026
| # Creates file "~/files.csv", among others | ||
| - id: file_changes | ||
| name: Gather file changes | ||
| uses: trilom/file-changes-action@1.2.4 |
Contributor
There was a problem hiding this comment.
looks like this isnt really being maintained anymore. Maybe replace with tj-actions/changed-files. IMO it would be even better to have the script use git to determine the changed files, which allows it to run locally easier.
Contributor
Author
There was a problem hiding this comment.
FYI this is the same thing used in duplicate-profile.yml. Not necessarily saying we shouldn't change it
Contributor
Author
There was a problem hiding this comment.
Updated. Scripts needed to be updated to alter their handling from the .csv reading to the environment variable pull. Re-tested with the new logic.
hcarter-775
force-pushed
the
add/category-existence-check
branch
2 times, most recently
from
July 27, 2026 18:07
7f01d0d to
6b4d7dd
Compare
|
matter-switch_coverage.xml
Minimum allowed coverage is Generated by 🐒 cobertura-action against 84e1a52 |
cjswedes
approved these changes
Jul 27, 2026
|
|
||
| - name: Run python script | ||
| env: | ||
| ALL_CHANGED_FILES: ${{ steps.changed-files.outputs.all_changed_files }} |
Contributor
There was a problem hiding this comment.
Probably worth a check that this still detects duplicate profiles
Contributor
Author
There was a problem hiding this comment.
Looks like it is still working as it did before:
Duplicate profile check: Warning - duplicate profiles detected.
2-button-battery-copy.yml == 2-button-battery.yml
hcarter-775
force-pushed
the
add/category-existence-check
branch
from
July 27, 2026 18:52
84e1a52 to
6b4d7dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Ensure that a category exists on the main component. Follow up to missing category issue found recently.
Testing Completed
See the following issue when a missing category is applied:
Duplicate profile checking still functions: