Skip to content

fix(table-core): avoid parent lookup re-entrancy#6441

Draft
KevinVandy wants to merge 1 commit into
betafrom
agent/audit-5630-parent-filter
Draft

fix(table-core): avoid parent lookup re-entrancy#6441
KevinVandy wants to merge 1 commit into
betafrom
agent/audit-5630-parent-filter

Conversation

@KevinVandy

@KevinVandy KevinVandy commented Jul 18, 2026

Copy link
Copy Markdown
Member

Closes #5630

What changed

  • Resolve structural parent rows from the core row model before consulting the pre-pagination model.
  • Preserve the pre-pagination fallback for generated parent rows, such as grouped rows.
  • Add a regression test for parent-aware column filter functions with both an initial filter and a subsequent filter update.

Why

During filtered-row-model construction, a custom filter function can call row.getParentRow(). The previous lookup entered the pre-pagination pipeline, which requests the filtered model currently being built and reads rowsById from an incomplete result. Looking up structural parents from the already-built core row model avoids this re-entrancy without changing support for generated parents.

Validation

  • pnpm --filter @tanstack/table-core test:lib --run (52 files, 1005 tests)
  • pnpm --filter @tanstack/table-core test:types
  • pnpm --filter @tanstack/table-core test:eslint
  • Prettier check on changed files
  • git diff --check

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 588b468e-16e3-48cc-9361-ddad623485ab

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/audit-5630-parent-filter

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Jul 18, 2026 •
edited
Loading

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 67547ea

Command Status Duration Result
nx affected --targets=test:eslint,test:sherif,t... ✅ Succeeded 8m 10s View ↗
nx run-many --targets=build --exclude=examples/** ✅ Succeeded 49s View ↗

☁️ Nx Cloud last updated this comment at 2026-07-18 00:42:11 UTC

@pkg-pr-new

pkg-pr-new Bot commented Jul 18, 2026

Copy link
Copy Markdown
More templates

@tanstack/alpine-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/alpine-table@6441

@tanstack/angular-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table@6441

@tanstack/angular-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/angular-table-devtools@6441

@tanstack/ember-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/ember-table@6441

@tanstack/lit-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/lit-table@6441

@tanstack/match-sorter-utils

npm i https://pkg.pr.new/TanStack/table/@tanstack/match-sorter-utils@6441

@tanstack/preact-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table@6441

@tanstack/preact-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/preact-table-devtools@6441

@tanstack/react-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table@6441

@tanstack/react-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/react-table-devtools@6441

@tanstack/solid-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table@6441

@tanstack/solid-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/solid-table-devtools@6441

@tanstack/svelte-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/svelte-table@6441

@tanstack/table-core

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-core@6441

@tanstack/table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/table-devtools@6441

@tanstack/vue-table

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table@6441

@tanstack/vue-table-devtools

npm i https://pkg.pr.new/TanStack/table/@tanstack/vue-table-devtools@6441

commit: 67547ea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Calling row.getParentRow() with expanded, filtered row models and initial filtering value throws an error

1 participant

@KevinVandy