Skip to content

fix: parenthesize multiple exception types in greatest_common_divisor#14942

Closed
mithunbabbira wants to merge 2 commits into
TheAlgorithms:masterfrom
mithunbabbira:fix-14929
Closed

fix: parenthesize multiple exception types in greatest_common_divisor#14942
mithunbabbira wants to merge 2 commits into
TheAlgorithms:masterfrom
mithunbabbira:fix-14929

Conversation

@mithunbabbira

Copy link
Copy Markdown

Summary

Fixes #14929maths/greatest_common_divisor.py uses Python 2 exception
syntax which is a SyntaxError in Python 3.

Problem

Line 76 used the Python 2 multi-exception form:

except IndexError, UnboundLocalError, ValueError:

This raises SyntaxError on Python 3, so the module cannot be imported.

Root Cause

Python 3 requires parenthesizing multiple exception types.

Solution

except (IndexError, UnboundLocalError, ValueError):

Testing

  • python3 -m py_compile maths/greatest_common_divisor.py — passes
  • python3 -m doctest maths/greatest_common_divisor.py -v — 6 tests pass

Notes

Minimal, single-line change. No behavior change.

Fixes #14929

@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@mithunbabbira, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed invalid labels Jul 19, 2026
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SyntaxError in maths/greatest_common_divisor.py — invalid Python 3 except clause

1 participant