Skip to content

fix: raise ValueError for multi-char separator in split()#14951

Closed
mithunbabbira wants to merge 2 commits into
TheAlgorithms:masterfrom
mithunbabbira:fix-14649
Closed

fix: raise ValueError for multi-char separator in split()#14951
mithunbabbira wants to merge 2 commits into
TheAlgorithms:masterfrom
mithunbabbira:fix-14649

Conversation

@mithunbabbira

Copy link
Copy Markdown

Summary

Fixes #14649 - split() silently returns wrong result for multi-character separators

Problem

The custom split() function compares each character in the input string with the separator. Because of that, a multi-character separator such as "--" is never matched.

Solution

Added validation to raise ValueError when separator length != 1, and simplified the implementation to use Python's built-in str.split().

Testing

  • All existing doctests pass
  • New doctest added for multi-char separator validation

Fixes #14649

@algorithms-keeper

Copy link
Copy Markdown

Closing this pull request as invalid

@mithunbabbira, this pull request is being closed as none of the checkboxes have been marked. It is important that you go through the checklist and mark the ones relevant to this pull request. Please read the Contributing guidelines.

If you're facing any problem on how to mark a checkbox, please read the following instructions:

  • Read a point one at a time and think if it is relevant to the pull request or not.
  • If it is, then mark it by putting a x between the square bracket like so: [x]

NOTE: Only [x] is supported so if you have put any other letter or symbol between the brackets, that will be marked as invalid. If that is the case then please open a new pull request with the appropriate changes.

@algorithms-keeper algorithms-keeper Bot added awaiting reviews This PR is ready to be reviewed invalid labels Jul 20, 2026
@algorithms-keeper algorithms-keeper Bot removed the awaiting reviews This PR is ready to be reviewed label Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

split silently returns wrong result for multi-character separators

1 participant