Extend rbran's parser robustness fixes with file-backed bounds and configurable limits (PE)#8357
Open
Weitao-Sun wants to merge 3 commits into
Open
Extend rbran's parser robustness fixes with file-backed bounds and configurable limits (PE)#8357Weitao-Sun wants to merge 3 commits into
Weitao-Sun wants to merge 3 commits into
Conversation
Replace magic-number loop guards in import directory and import lookup table parsing with section-backed bounds. Add IsRVARangeBackedByFile helper that validates every byte in the given RVA range resolves to a file-backed offset, rather than only its two endpoints, and guard the import lookup table's section-derived bound against a section header that declares more raw data than the file actually contains. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Split out from #8303 per review feedback, containing the PE portion only. (Mach-O is being merged in #8303; ELF is a separate PR.)
Builds on rbran's parser robustness fixes with the following improvements:
PEView::Init: fixes a divide-by-zero FPE and adds a loop guard against malformed import directory data.IsRVARangeBackedByFile, which resolves and validates every RVA in a range independently (each byte finds its own containing section), rather than resolving only the first RVA's section and checking just the first/last byte — which could give a wrong answer if the range crosses a section boundary.