Skip to content

Fix go-critic errors - #101

Merged
WebReflection merged 1 commit into
WebReflection:mainfrom
mfinelli:gocriticfixes
Jul 29, 2026
Merged

Fix go-critic errors#101
WebReflection merged 1 commit into
WebReflection:mainfrom
mfinelli:gocriticfixes

Conversation

@mfinelli

Copy link
Copy Markdown
Contributor

go-critic makes a couple of style complaints that I've fixed.

@WebReflection

WebReflection commented Jun 19, 2026

Copy link
Copy Markdown
Owner

apologies for being slow on this ... I'll ask AI to validate this suggestion as I am not a go expert

@mfinelli

Copy link
Copy Markdown
Contributor Author

Hi @WebReflection have you had a chance to look at this (or have your AI look at it)? Cheers

@WebReflection
WebReflection merged commit 4303f4d into WebReflection:main Jul 29, 2026
@WebReflection

Copy link
Copy Markdown
Owner

@mfinelli apologies that's indeed what was making CI not happy, apparently, it's in ... on main ... anything else I should do?

@WebReflection

Copy link
Copy Markdown
Owner

@mfinelli actually no ... CI is still complaining https://github.com/WebReflection/flatted/actions/runs/30472877158 ... I can't have green CI anymore in here due GO shenanigans I don't understand, any help or follow up PR would be more than welcomed, otherwise I need to drop GO in here, thank you!

@WebReflection

Copy link
Copy Markdown
Owner

@mfinelli basically ...

Error: /home/runner/work/flatted/flatted/golang/pkg/flatted/flatted.go:35:88: inline: Constant reflect.Ptr should be inlined (govet)
  		if kind == reflect.String || kind == reflect.Slice || kind == reflect.Map || kind == reflect.Ptr {
  		                                                                                     ^
  Error: /home/runner/work/flatted/flatted/golang/pkg/flatted/flatted.go:62:20: inline: Constant reflect.Ptr should be inlined (govet)
  		for rv.Kind() == reflect.Ptr && !rv.IsNil() {

@WebReflection

Copy link
Copy Markdown
Owner

I might be able to fix that via AI though ...

@WebReflection

Copy link
Copy Markdown
Owner

@mfinelli I probably just did ... thank you, let me know if there's anything else I should do in here

@mfinelli

Copy link
Copy Markdown
Contributor Author

Hi @WebReflection yes your fix for the CI failures is correct. Go vet is basically just another linting tool. Nothing else from me, just waiting for a release :)
Cheers!

@WebReflection

Copy link
Copy Markdown
Owner

@mfinelli it's up and running as flatted@3.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants