Fix go-critic errors - #101
Conversation
|
apologies for being slow on this ... I'll ask AI to validate this suggestion as I am not a go expert |
|
Hi @WebReflection have you had a chance to look at this (or have your AI look at it)? Cheers |
|
@mfinelli apologies that's indeed what was making CI not happy, apparently, it's in ... on main ... anything else I should do? |
|
@mfinelli actually no ... CI is still complaining https://github.com/WebReflection/flatted/actions/runs/30472877158 ... I can't have green CI anymore in here due GO shenanigans I don't understand, any help or follow up PR would be more than welcomed, otherwise I need to drop GO in here, thank you! |
|
@mfinelli basically ... |
|
I might be able to fix that via AI though ... |
|
@mfinelli I probably just did ... thank you, let me know if there's anything else I should do in here |
|
Hi @WebReflection yes your fix for the CI failures is correct. Go vet is basically just another linting tool. Nothing else from me, just waiting for a release :) |
|
@mfinelli it's up and running as |
go-critic makes a couple of style complaints that I've fixed.