Skip to content

Docs: Add the missing $has_custom_overlay param to the Navigation block DocBlock #12640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itzmekhokan wants to merge 1 commit into from
Closed

Docs: Add the missing $has_custom_overlay param to the Navigation block DocBlock #12640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/wp-includes/blocks/navigation.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,7 +670,8 @@ private static function get_responsive_container_classes( $is_hidden_by_default,
*
* @since 7.0.0
*
* @param array $colors The colors array.
* @param bool $has_custom_overlay Whether a custom overlay is used.
* @param array $colors The colors array.

@westonruter westonruter Jul 22, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we're touching the docblock here, we should take the opportunity to provide the full PHPStan typing for this param. So this could be done by adding another tag at the bottom of the docblock:

* @phpstan-param array{
*     overlay_inline_styles: string,
* } $colors

* @return string Returns the overlay inline styles.
*/
private static function get_overlay_inline_styles( $has_custom_overlay, $colors ) {
Expand Down
Loading