Skip to content

Tests: Refactor test_wp_cache_get_multiple() and test_wp_cache_delete_multiple()#12642

Open
jorgelr771 wants to merge 1 commit into
WordPress:trunkfrom
jorgelr771:add/tests-cache-multiple-65693
Open

Tests: Refactor test_wp_cache_get_multiple() and test_wp_cache_delete_multiple()#12642
jorgelr771 wants to merge 1 commit into
WordPress:trunkfrom
jorgelr771:add/tests-cache-multiple-65693

Conversation

@jorgelr771

@jorgelr771 jorgelr771 commented Jul 22, 2026

Copy link
Copy Markdown

Trac ticket:
https://core.trac.wordpress.org/ticket/65693


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copilot AI review requested due to automatic review settings July 22, 2026 12:58
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props jorgelopezrepiso.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@jorgelr771 jorgelr771 changed the title Tests: Refactor test_wp_cache_get_multiple() and test_wp_cache_delete… Tests: Refactor test_wp_cache_get_multiple() and test_wp_cache_delete_multiple() Jul 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors and strengthens the unit tests covering wp_cache_get_multiple() and wp_cache_delete_multiple() to better validate group isolation and expected behavior for missing keys, aligning with the cache API’s documented return values.

Changes:

  • Expand test_wp_cache_get_multiple() to cover: keys missing in the requested group, keys present only in another group, and same key stored in two groups with different values.
  • Expand test_wp_cache_delete_multiple() to include a missing key, and add post-conditions verifying deletions actually occurred only within the targeted group.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants