Tests: Refactor test_wp_cache_get_multiple() and test_wp_cache_delete_multiple()#12642
Tests: Refactor test_wp_cache_get_multiple() and test_wp_cache_delete_multiple()#12642jorgelr771 wants to merge 1 commit into
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
There was a problem hiding this comment.
Pull request overview
This PR refactors and strengthens the unit tests covering wp_cache_get_multiple() and wp_cache_delete_multiple() to better validate group isolation and expected behavior for missing keys, aligning with the cache API’s documented return values.
Changes:
- Expand
test_wp_cache_get_multiple()to cover: keys missing in the requested group, keys present only in another group, and same key stored in two groups with different values. - Expand
test_wp_cache_delete_multiple()to include a missing key, and add post-conditions verifying deletions actually occurred only within the targeted group.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Trac ticket:
https://core.trac.wordpress.org/ticket/65693
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.