Skip to content

Security: Harden taxonomy tab handler in post.js#12643

Draft
SainathPoojary wants to merge 1 commit into
WordPress:trunkfrom
SainathPoojary:fix/65572
Draft

Security: Harden taxonomy tab handler in post.js#12643
SainathPoojary wants to merge 1 commit into
WordPress:trunkfrom
SainathPoojary:fix/65572

Conversation

@SainathPoojary

Copy link
Copy Markdown

This PR hardens the taxonomy tab click handler in wp-admin/js/post.js to avoid passing a raw href value into jQuery’s $() constructor. This mitigates the risk of unintended HTML parsing or CSS selector injection.

Trac ticket: #65572

Copilot AI review requested due to automatic review settings July 22, 2026 13:26

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR hardens the hierarchical taxonomy tab handler in the post editor admin script by avoiding passing an attribute-derived string directly into jQuery’s $() constructor, reducing exposure to unintended HTML parsing or selector injection.

Changes:

  • Switch tab targeting from href to aria-controls for identifying the associated panel.
  • Resolve the target panel via document.getElementById() and pass the resulting element to jQuery.
  • Update the “all items” comparison to match the new non-#-prefixed identifier format.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions

Copy link
Copy Markdown

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants