Security: Harden taxonomy tab handler in post.js#12643
Draft
SainathPoojary wants to merge 1 commit into
Draft
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens the hierarchical taxonomy tab handler in the post editor admin script by avoiding passing an attribute-derived string directly into jQuery’s $() constructor, reducing exposure to unintended HTML parsing or selector injection.
Changes:
- Switch tab targeting from
hreftoaria-controlsfor identifying the associated panel. - Resolve the target panel via
document.getElementById()and pass the resulting element to jQuery. - Update the “all items” comparison to match the new non-
#-prefixed identifier format.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR hardens the taxonomy tab click handler in wp-admin/js/post.js to avoid passing a raw href value into jQuery’s $() constructor. This mitigates the risk of unintended HTML parsing or CSS selector injection.
Trac ticket: #65572