fix(jsonrpc): avoid wrapping tasks in list responses#998
Open
014-code wants to merge 1 commit into
Open
Conversation
Register EventKind and StreamingEventKind adapters only for their declared interface types so List<Task> serializes task fields directly while JSON-RPC oneof results and streaming events keep their wrapper shape. Add regression coverage for ListTasksResult/ListTasksResponse serialization and keep push notification streaming payload coverage passing. This fixes a2aproject#843
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StreamingEventKindserialization from wrapping concreteTaskvalues inside ordinaryList<Task>payloads.EventKindhandling soSendMessageResponseoneof results still keep the expectedtask/messagewrapper.Related Issue
This fixes #843.
Tests
ListTasksResultandListTasksResponseto ensuretasks[]items serialize as direct task objects without an extrataskwrapper.SendMessageResponsestill keeps theEventKindwrapper.Passed:
mvn -pl jsonrpc-common -am -Dtest=TaskSerializationTest,StreamingEventKindSerializationTest -Dsurefire.failIfNoSpecifiedTests=false test -B -ntp -Dstyle.color=nevermvn -pl server-common,extras/queue-manager-replicated/core -am -Dtest=PushNotificationSenderTest,EventSerializationTest -Dsurefire.failIfNoSpecifiedTests=false test -B -ntp -Dstyle.color=never