Improve Property Types - #6487
Conversation
|
@kevinrr888 Checking if you are still available for discussion on this issue, Looking for your guidance/opinion over the expected changes |
…cond version of validPath()
|
@ctubbsii Proposal for additional PropertyType.STRING validation: Found groups of Properties of PropertyType.STRING that could potentially have new PropertyType: create new PropertyType.PASSWORD (is password unique enough to need its own validation? Can a password be empty/null) for validating a password for these Properties:
create new PropertyType.ADDRESS (or IP) for validating if a string is a valid IP format (ex: 0.0.0.0)
Probably unnecessary since it looks like there is a list of enabled protocols server side that the protocol must match. Create new PropertyType.PROTOCOL (what does protocol look like) for validating a protocol for this group of Property:
Alternative validation for these Properties that are PropertyType.STRING can be done by creating a new ValidString() method for the PropertyType.STRING. ValidString() can check for the specific string cases mentioned above, and return true for all other strings, currently PropertyType.STRING always returns true to validate any string |
ServerConfigCheckRunner.javaand intoProperty.javaas a static method that returns a Set of the required properties, added more detailed Javadoc to the method.PropertyType.PATHandPropertyType.URIPropertyType.javaThis pr resolves #6112
TODO:
PropertyType.STRING, determine which ones need additional validationRefer to discussion over property types on pr #5348