Remove compaction related TODOs - #6491
Open
Amemeda wants to merge 4 commits into
Open
Conversation
DomGarguilo
requested changes
Jul 28, 2026
Amemeda
marked this pull request as ready for review
July 28, 2026 19:39
Amemeda
commented
Jul 29, 2026
dlmarion
reviewed
Jul 31, 2026
| return tm.stream().allMatch(t -> t.getExternalCompactions().isEmpty()); | ||
| } | ||
| } while (count > 0); | ||
| }); |
Contributor
There was a problem hiding this comment.
We could probably also add a call to ExternalCompactionUtil.getCompactionsRunningOnCompactors to confirm that Compactors are not running compactions for user tables.
Contributor
Author
There was a problem hiding this comment.
Add this in the return? or after the wait block?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ExternalCompaction4_IT, the test is already using a valid compaction server config cs4.ExternalCompactionMetricsIT.testMetrics. TODO was misleading, the code was already not checking the queue, but the ECOMP metadata. Reworked this check to ensure all compaction jobs have completed by waiting for the ECOMP metadata to be cleared from Accumulo metadata.This pr resolves 2 TODOs from #2699