GH-49255: [Python] Fix pandas Categorical DeprecationWarnings in tests#50543
Merged
Conversation
Contributor
Author
rok
reviewed
Jul 18, 2026
rok
left a comment
rok
left a comment
Member
There was a problem hiding this comment.
This seems good, I would add erroring on deprecation warning to pytest perhaps so we don't backslide.
Member
|
Yay, thanks for the contribution @GujaLomsadze! 🎉 |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 59c3872. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 44 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Member
|
Thanks for the PR @GujaLomsadze ! |
rok
pushed a commit
that referenced
this pull request
Jul 22, 2026
…as 3.X deprecation (#50608) ### Rationale for this change Follow-up to #50543. `test_categorical_order_survives_roundtrip` constructs a `pd.Categorical` with value "a" not in categories `["b","c","d"]`. pandas 3.0.3 raises a deprecation for out-of-category values, which #50543's filterwarnings config now turns into an error - failing nightly wheels across platforms. ### What changes are included in this PR? Replace the out-of-category `"a"` value with an explicit `None`, preserving the test's intent (ordered categorical with non-sorted categories survives a Parquet roundtrip, ARROW-6302) plus a null. ### Are these changes tested? Yes. Reproduced the failure with pandas 3.0.3, confirmed the test passes after the change; all categorical tests in the module pass. ### Are there any user-facing changes? No. Closes #50579. * GitHub Issue: #50579 Authored-by: Guja <127162872+GujaLomsadze@users.noreply.github.com> Signed-off-by: Rok Mihevc <rok@mihevc.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
pandas 3.0.0 deprecated constructing or casting to a
Categoricalwithnon-NA values that are not present in the specified
dtype.categories.This surfaces as DeprecationWarnings in the PyArrow
test suite when run against pandas >= 3.0 (GH-49255), in test_category
and test_category_implicit_from_pandas.
What changes are included in this PR?
cat_strings_with_nacolumn (relied onsilent 'qux' -> NaN; redundant, cat_strings already carries nulls).
(['a','b',None]) instead of out-of-category 'c'.
Are these changes tested?
Yes - test-only. Verified no DeprecationWarning under pandas 3.0.3.
Are there any user-facing changes?
No.
Closes #49255.