Skip to content

Fix overly broad classpath scanning in ReflectUtil.getClassesWithAnnotation()#13427

Draft
vishesh92 wants to merge 2 commits into
apache:4.22from
shapeblue:fix-overly-broad-classpath-scanning
Draft

Fix overly broad classpath scanning in ReflectUtil.getClassesWithAnnotation()#13427
vishesh92 wants to merge 2 commits into
apache:4.22from
shapeblue:fix-overly-broad-classpath-scanning

Conversation

@vishesh92

@vishesh92 vishesh92 commented Jun 16, 2026

Copy link
Copy Markdown
Member

Description

Production logs show a recurring WARN at startup:
"could not get type for name org.conscrypt.AllocatedBuffer"
(org.reflections.ReflectionsException / ClassNotFoundException)

Root cause: ReflectUtil.getClassesWithAnnotation() uses ClasspathHelper.forPackage() to collect URLs to scan, but this returns all classpath entries (JARs/directories), not just those containing the target package. The Reflections library then scans every .class file in every JAR — including Netty's ConscryptAlpnSslEngine$BufferAdapter which references the optional org.conscrypt.AllocatedBuffer type. During expandSuperTypes(), Reflections tries Class.forName() on that type and fails because Conscrypt is not (and need not be) on the classpath.

The fix adds a FilterBuilder that restricts bytecode scanning to only classes whose fully-qualified names match the requested packages. This prevents Reflections from processing unrelated classes (e.g., io.netty.handler.ssl.*), eliminating the warning and reducing startup time by skipping thousands of irrelevant class files.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

…tation()

Production logs show a recurring WARN at startup:
  "could not get type for name org.conscrypt.AllocatedBuffer"
  (org.reflections.ReflectionsException / ClassNotFoundException)

Root cause: ReflectUtil.getClassesWithAnnotation() uses
ClasspathHelper.forPackage() to collect URLs to scan, but this
returns all classpath entries (JARs/directories), not just those
containing the target package. The Reflections library then scans
every .class file in every JAR — including Netty's
ConscryptAlpnSslEngine$BufferAdapter which references the optional
org.conscrypt.AllocatedBuffer type. During expandSuperTypes(),
Reflections tries Class.forName() on that type and fails because
Conscrypt is not (and need not be) on the classpath.

The fix adds a FilterBuilder that restricts bytecode scanning to
only classes whose fully-qualified names match the requested
packages. This prevents Reflections from processing unrelated
classes (e.g., io.netty.handler.ssl.*), eliminating the warning
and reducing startup time by skipping thousands of irrelevant
class files.

Signed-off-by: Ganesh Maharaj Mahalingam <g.mahalingam@apple.com>
@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.69%. Comparing base (8e933b7) to head (6820db8).
⚠️ Report is 67 commits behind head on 4.22.

Files with missing lines Patch % Lines
...ils/src/main/java/com/cloud/utils/ReflectUtil.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #13427      +/-   ##
============================================
+ Coverage     17.67%   17.69%   +0.01%     
- Complexity    15792    15832      +40     
============================================
  Files          5922     5925       +3     
  Lines        533167   533537     +370     
  Branches      65210    65273      +63     
============================================
+ Hits          94246    94416     +170     
- Misses       428276   428440     +164     
- Partials      10645    10681      +36     
Flag Coverage Δ
uitests 3.69% <ø> (-0.01%) ⬇️
unittests 18.77% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18273

@DaanHoogland DaanHoogland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-16355)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 62791 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13427-t16355-kvm-ol8.zip
Smoke tests completed. 141 look OK, 8 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestExtensions>:setup Error 0.00 test_extension_custom.py
ContextSuite context=TestExtensions>:setup Error 0.00 test_extension_custom_action_lifecycle.py
test_01_create_extension Error 0.00 test_extension_lifecycle.py
test_02_create_extension_type_fail Error 0.00 test_extension_lifecycle.py
test_03_create_extension_name_fail Error 0.00 test_extension_lifecycle.py
test_04_update_extension Error 0.00 test_extension_lifecycle.py
test_05_register_unregister_extension Error 0.05 test_extension_lifecycle.py
test_06_register_extension_already_fail Error 0.05 test_extension_lifecycle.py
test_07_delete_extension_registered_resource_fail Error 0.05 test_extension_lifecycle.py
test_08_extension_sync Error 0.00 test_extension_lifecycle.py
test_09_extension_deploy_vm Error 0.05 test_extension_lifecycle.py
test_01_add_primary_storage_disabled_host Failure 117.28 test_primary_storage.py
test_create_pvlan_network Error 0.10 test_pvlan.py
ContextSuite context=TestSharedFSLifecycle>:setup Error 0.00 test_sharedfs_lifecycle.py
test_01_webhook_deliveries Error 5.26 test_webhook_delivery.py
test_01_create_webhook_admin_local Error 1.08 test_webhook_lifecycle.py
test_02_create_webhook_admin_domain Error 1.08 test_webhook_lifecycle.py
test_03_create_webhook_admin_global Error 1.11 test_webhook_lifecycle.py
test_04_create_webhook_domainadmin_local Error 5.58 test_webhook_lifecycle.py
test_05_create_webhook_domainadmin_subdomain Error 6.75 test_webhook_lifecycle.py
test_06_create_webhook_domainadmin_global_negative Error 5.63 test_webhook_lifecycle.py
test_07_create_webhook_user_local Error 5.24 test_webhook_lifecycle.py
test_08_create_webhook_user_domain Error 5.37 test_webhook_lifecycle.py
test_09_create_webhook_user_gloabl Error 5.25 test_webhook_lifecycle.py
test_10_create_webhook_admin_advanced Error 5.34 test_webhook_lifecycle.py
test_11_update_webhook Error 5.34 test_webhook_lifecycle.py
test_12_list_user_webhook_deliveries Error 5.40 test_webhook_lifecycle.py
test_13_webhook_execute_delivery Error 5.29 test_webhook_lifecycle.py

@weizhouapache weizhouapache added this to the 4.22.2 milestone Jun 29, 2026
@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18427

@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-16455)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50713 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13427-t16455-kvm-ol8.zip
Smoke tests completed. 142 look OK, 7 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestExtensions>:setup Error 0.00 test_extension_custom.py
ContextSuite context=TestExtensions>:setup Error 0.00 test_extension_custom_action_lifecycle.py
test_01_create_extension Error 0.01 test_extension_lifecycle.py
test_02_create_extension_type_fail Error 0.00 test_extension_lifecycle.py
test_03_create_extension_name_fail Error 0.00 test_extension_lifecycle.py
test_04_update_extension Error 0.00 test_extension_lifecycle.py
test_05_register_unregister_extension Error 0.05 test_extension_lifecycle.py
test_06_register_extension_already_fail Error 0.05 test_extension_lifecycle.py
test_07_delete_extension_registered_resource_fail Error 0.04 test_extension_lifecycle.py
test_08_extension_sync Error 0.00 test_extension_lifecycle.py
test_09_extension_deploy_vm Error 0.04 test_extension_lifecycle.py
test_01_add_primary_storage_disabled_host Failure 117.41 test_primary_storage.py
ContextSuite context=TestSharedFSLifecycle>:setup Error 0.00 test_sharedfs_lifecycle.py
test_01_webhook_deliveries Error 5.50 test_webhook_delivery.py
test_01_create_webhook_admin_local Error 1.08 test_webhook_lifecycle.py
test_02_create_webhook_admin_domain Error 1.08 test_webhook_lifecycle.py
test_03_create_webhook_admin_global Error 1.08 test_webhook_lifecycle.py
test_04_create_webhook_domainadmin_local Error 5.46 test_webhook_lifecycle.py
test_05_create_webhook_domainadmin_subdomain Error 6.69 test_webhook_lifecycle.py
test_06_create_webhook_domainadmin_global_negative Error 5.62 test_webhook_lifecycle.py
test_07_create_webhook_user_local Error 5.45 test_webhook_lifecycle.py
test_08_create_webhook_user_domain Error 5.77 test_webhook_lifecycle.py
test_09_create_webhook_user_gloabl Error 5.71 test_webhook_lifecycle.py
test_10_create_webhook_admin_advanced Error 5.15 test_webhook_lifecycle.py
test_11_update_webhook Error 5.30 test_webhook_lifecycle.py
test_12_list_user_webhook_deliveries Error 5.53 test_webhook_lifecycle.py
test_13_webhook_execute_delivery Error 5.55 test_webhook_lifecycle.py

@nvazquez

Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@nvazquez a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18576

@nvazquez

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@nvazquez a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-16580)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51516 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13427-t16580-kvm-ol8.zip
Smoke tests completed. 143 look OK, 6 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestExtensions>:setup Error 0.00 test_extension_custom.py
ContextSuite context=TestExtensions>:setup Error 0.00 test_extension_custom_action_lifecycle.py
test_01_create_extension Error 0.00 test_extension_lifecycle.py
test_02_create_extension_type_fail Error 0.00 test_extension_lifecycle.py
test_03_create_extension_name_fail Error 0.00 test_extension_lifecycle.py
test_04_update_extension Error 0.00 test_extension_lifecycle.py
test_05_register_unregister_extension Error 0.07 test_extension_lifecycle.py
test_06_register_extension_already_fail Error 0.07 test_extension_lifecycle.py
test_07_delete_extension_registered_resource_fail Error 0.06 test_extension_lifecycle.py
test_08_extension_sync Error 0.00 test_extension_lifecycle.py
test_09_extension_deploy_vm Error 0.07 test_extension_lifecycle.py
test_01_add_primary_storage_disabled_host Failure 109.37 test_primary_storage.py
test_01_webhook_deliveries Error 7.12 test_webhook_delivery.py
test_01_create_webhook_admin_local Error 1.10 test_webhook_lifecycle.py
test_02_create_webhook_admin_domain Error 1.11 test_webhook_lifecycle.py
test_03_create_webhook_admin_global Error 1.10 test_webhook_lifecycle.py
test_04_create_webhook_domainadmin_local Error 8.04 test_webhook_lifecycle.py
test_05_create_webhook_domainadmin_subdomain Error 8.45 test_webhook_lifecycle.py
test_06_create_webhook_domainadmin_global_negative Error 7.62 test_webhook_lifecycle.py
test_07_create_webhook_user_local Error 7.06 test_webhook_lifecycle.py
test_08_create_webhook_user_domain Error 6.87 test_webhook_lifecycle.py
test_09_create_webhook_user_gloabl Error 6.91 test_webhook_lifecycle.py
test_10_create_webhook_admin_advanced Error 6.90 test_webhook_lifecycle.py
test_11_update_webhook Error 6.93 test_webhook_lifecycle.py
test_12_list_user_webhook_deliveries Error 6.91 test_webhook_lifecycle.py
test_13_webhook_execute_delivery Error 7.45 test_webhook_lifecycle.py

@DaanHoogland
DaanHoogland marked this pull request as draft July 20, 2026 12:17
@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan

Copy link
Copy Markdown

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18621

@vishesh92

Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@vishesh92 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@DaanHoogland

Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan

Copy link
Copy Markdown

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-16589)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 69510 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13427-t16589-kvm-ol8.zip
Smoke tests completed. 134 look OK, 15 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestNonStrictAffinityGroups>:setup Error 0.00 test_nonstrict_affinity_group.py
test_01_add_primary_storage_disabled_host Error 39.08 test_primary_storage.py
test_01_primary_storage_nfs Error 0.22 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 0.35 test_primary_storage.py
test_01_primary_storage_scope_change Error 0.15 test_primary_storage_scope.py
ContextSuite context=TestPrivateGwACL>:setup Error 0.00 test_privategw_acl.py
test_10_project_activation Error 8.63 test_projects.py
ContextSuite context=TestResetVmOnReboot>:setup Error 0.00 test_reset_vm_on_reboot.py
ContextSuite context=TestRestoreVM>:setup Error 0.00 test_restore_vm.py
ContextSuite context=TestVMSchedule>:setup Error 0.00 test_vm_schedule.py
ContextSuite context=TestRouterDnsService>:setup Error 0.00 test_router_dnsservice.py
ContextSuite context=TestIsolatedNetworks>:setup Error 0.00 test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup Error 0.00 test_routers_network_ops.py
ContextSuite context=TestCpuCapServiceOfferings>:setup Error 0.00 test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup Error 0.31 test_service_offerings.py
test_02_create_template_with_checksum_sha1 Error 65.68 test_templates.py
test_09_list_templates_download_details Failure 0.08 test_templates.py
ContextSuite context=TestDeployVM>:setup Error 0.00 test_vm_life_cycle.py
test_01_migrate_VM_and_root_volume Error 1.40 test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks Error 1.34 test_vm_life_cycle.py
test_01_secure_vm_migration Error 80.63 test_vm_life_cycle.py
test_02_unsecure_vm_migration Error 233.35 test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration Error 151.41 test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration Error 151.46 test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup Error 6.47 test_vm_life_cycle.py
test_01_unmanage_vm_cycle_persistent_domain Error 4.11 test_vm_lifecycle_unmanage_kvm_import.py
test_02_unmanage_stopped_vm_cycle_persistent_domain Error 4.00 test_vm_lifecycle_unmanage_kvm_import.py
ContextSuite context=TestUnmanageKvmVM>:teardown Error 4.03 test_vm_lifecycle_unmanage_kvm_import.py
ContextSuite context=TestVmSnapshot>:setup Error 6.44 test_vm_snapshots.py

@blueorangutan

Copy link
Copy Markdown

[SF] Trillian test result (tid-16595)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 65744 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13427-t16595-kvm-ol8.zip
Smoke tests completed. 139 look OK, 10 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_events_resource Error 9.36 test_events_resource.py
test_01_events_resource Error 9.36 test_events_resource.py
ContextSuite context=TestDeployVirtioSCSIVM>:setup Error 0.00 test_deploy_virtio_scsi_vm.py
ContextSuite context=TestInternalLb>:setup Error 0.00 test_internal_lb.py
ContextSuite context=TestDomainsServiceOfferings>:setup Error 1520.75 test_domain_service_offerings.py
test_01_invalid_upgrade_kubernetes_cluster Failure 0.01 test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster Failure 0.07 test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 0.00 test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster Failure 0.00 test_kubernetes_clusters.py
test_11_test_unmanaged_cluster_lifecycle Error 0.00 test_kubernetes_clusters.py
test_12_test_deploy_cluster_different_offerings_per_node_type Failure 0.00 test_kubernetes_clusters.py
ContextSuite context=TestListVolumes>:setup Error 0.00 test_list_volumes.py
ContextSuite context=TestMetrics>:setup Error 0.00 test_metrics_api.py
test_nic_secondaryip_add_remove Error 1517.89 test_multipleips_per_nic.py
ContextSuite context=TestPrivateGwACL>:setup Error 0.00 test_privategw_acl.py
ContextSuite context=TestRouterDnsService>:setup Error 0.00 test_router_dnsservice.py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants