Skip to content

ui: Do not send projectid=-1 on the Quota summary page#13658

Open
winterhazel wants to merge 1 commit into
apache:mainfrom
winterhazel:ignore-projectid-on-quotasummary
Open

ui: Do not send projectid=-1 on the Quota summary page#13658
winterhazel wants to merge 1 commit into
apache:mainfrom
winterhazel:ignore-projectid-on-quotasummary

Conversation

@winterhazel

Copy link
Copy Markdown
Member

Description

This fixes a minor bug in the Quota UI.

Enabling the projects toggle on any page makes the UI send projectid=-1 to APIs; however, this parameter makes the Quota summary page display an error. This is because a special handling for projectid=-1 was never implemented on quotaSummary, since it already returns entries for the accessible projects ever since it was introduced.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Without the patch, I verified that enabling the projects toggle and switching to the Quota summary page would display an error.

Error when accessing the Quota summary page image

Applying these changes allows the Quota summary page to load as intended when repeating the same steps.

Quota summary page loaded successfully image

@winterhazel

Copy link
Copy Markdown
Member Author

@blueorangutan ui

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 3.41%. Comparing base (fc83241) to head (5e76700).

❗ There is a different number of reports uploaded between BASE (fc83241) and HEAD (5e76700). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (fc83241) HEAD (5e76700)
unittests 1 0
Additional details and impacted files
@@              Coverage Diff              @@
##               main   #13658       +/-   ##
=============================================
- Coverage     19.64%    3.41%   -16.24%     
=============================================
  Files          6368      487     -5881     
  Lines        575109    41862   -533247     
  Branches      70371     7910    -62461     
=============================================
- Hits         112994     1429   -111565     
+ Misses       449829    40234   -409595     
+ Partials      12286      199    -12087     
Flag Coverage Δ
uitests 3.41% <ø> (-0.01%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland

Copy link
Copy Markdown
Contributor

@winterhazel , would it make sense to have the quota summary page not show the project toggle instead?

Also, unknown parameters should be gracefully ignored in the API layer, can you show the logging for the call?

@GaOrtiga

Copy link
Copy Markdown
Collaborator

@winterhazel , would it make sense to have the quota summary page not show the project toggle instead?

Also, unknown parameters should be gracefully ignored in the API layer, can you show the logging for the call?

+1 on the second part
@winterhazel is there a reason to not add the handling directly on the API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants