docs: clarify SparkPhysicalExprAdapter cast checks differ from CometCast.isSupported - #5232
Open
mbutrovich wants to merge 1 commit into
Open
docs: clarify SparkPhysicalExprAdapter cast checks differ from CometCast.isSupported#5232mbutrovich wants to merge 1 commit into
mbutrovich wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
SparkPhysicalExprAdapter::replace_with_spark_cast(native, scan-time Parquet schema evolution) andCometCast.isSupported(Scala, CatalystCastexpression legality) enforce two different Spark surfaces but feed the same native cast kernel, which made it easy to assume they should cross-check each other. Nothing is broken today, but neither function said which Spark reference it is supposed to track, inviting a future change to conflate the two.What changes are included in this PR?
replace_with_spark_castnoting it mirrors Spark's vectorized Parquet reader (ParquetVectorUpdaterFactory.getUpdater) for schema-evolution casts, notCometCast.isSupported.cast_arraynaming both independent callers (CometCast.isSupportedfor the expression path, the schema adapter for the scan path) that are expected to have already gated the cast before it reaches the native kernel.How are these changes tested?
Comment-only change, no behavior change. No new tests.