Skip to content

HBASE-30312 Update website to ReactRouter v8 - #8521

Open
yuriipalam wants to merge 4 commits into
apache:masterfrom
yuriipalam:HBASE-30312
Open

HBASE-30312 Update website to ReactRouter v8#8521
yuriipalam wants to merge 4 commits into
apache:masterfrom
yuriipalam:HBASE-30312

Conversation

@yuriipalam

@yuriipalam yuriipalam commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

This PR updates to ReactRouter v8 adopting the code and other deps for it. It also resolves CVEs from the old versions.
Initial PR by dependabot: #8507

dependabot Bot and others added 2 commits July 27, 2026 06:13
@dependabot
Bump react-router, @react-router/node, @react-router/serve, fumadocs-…
4aa0b79 
…core, fumadocs-ui and @react-router/dev

Bumps [react-router](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router), [@react-router/node](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-node), [@react-router/serve](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-serve), [fumadocs-core](https://github.com/fuma-nama/fumadocs), [fumadocs-ui](https://github.com/fuma-nama/fumadocs) and [@react-router/dev](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dev). These dependencies needed to be updated together.

Updates `react-router` from 7.16.0 to 8.3.0
- [Release notes](https://github.com/remix-run/react-router/releases)
- [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router/CHANGELOG.md)
- [Commits](https://github.com/remix-run/react-router/commits/react-router@8.3.0/packages/react-router)

Updates `@react-router/node` from 7.16.0 to 8.3.0
- [Release notes](https://github.com/remix-run/react-router/releases)
- [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router-node/CHANGELOG.md)
- [Commits](https://github.com/remix-run/react-router/commits/@react-router/node@8.3.0/packages/react-router-node)

Updates `@react-router/serve` from 7.16.0 to 8.3.0
- [Release notes](https://github.com/remix-run/react-router/releases)
- [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router-serve/CHANGELOG.md)
- [Commits](https://github.com/remix-run/react-router/commits/@react-router/serve@8.3.0/packages/react-router-serve)

Updates `fumadocs-core` from 16.0.10 to 16.13.0
- [Release notes](https://github.com/fuma-nama/fumadocs/releases)
- [Commits](https://github.com/fuma-nama/fumadocs/compare/fumadocs-core@16.0.10...fumadocs@16.13.0)

Updates `fumadocs-ui` from 16.0.10 to 16.13.0
- [Release notes](https://github.com/fuma-nama/fumadocs/releases)
- [Commits](https://github.com/fuma-nama/fumadocs/compare/fumadocs-ui@16.0.10...fumadocs@16.13.0)

Updates `@react-router/dev` from 7.16.0 to 8.3.0
- [Release notes](https://github.com/remix-run/react-router/releases)
- [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router-dev/CHANGELOG.md)
- [Commits](https://github.com/remix-run/react-router/commits/@react-router/dev@8.3.0/packages/react-router-dev)

---
updated-dependencies:
- dependency-name: react-router
  dependency-version: 8.3.0
  dependency-type: direct:production
- dependency-name: "@react-router/node"
  dependency-version: 8.3.0
  dependency-type: direct:production
- dependency-name: "@react-router/serve"
  dependency-version: 8.3.0
  dependency-type: direct:production
- dependency-name: fumadocs-core
  dependency-version: 16.13.0
  dependency-type: direct:production
- dependency-name: fumadocs-ui
  dependency-version: 16.13.0
  dependency-type: direct:production
- dependency-name: "@react-router/dev"
  dependency-version: 8.3.0
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
@yuriipalam
Migrate to ReactRouter v8
57b0341
PDavid
PDavid reviewed Aug 3, 2026
View reviewed changes
Comment thread hbase-website/package.json
"type": "module",
"engines": {
"node": ">=22.12.0"
"node": ">=24.18.1"

@PDavid PDavid Aug 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also update the Node.js version which is installed by Maven https://github.com/apache/hbase/blob/master/hbase-website/pom.xml#L35 , otherwise we will get unsupported engine errors.

(Also super-minor but the module README has the Node v22 mentioned.)

@yuriipalam yuriipalam Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, done

PDavid
PDavid approved these changes Aug 4, 2026
View reviewed changes

@PDavid PDavid left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for taking care of this. 👍

I checked locally, built the site, docs - both look fine. ✔️

Comment thread hbase-website/pom.xml
</configuration>
</execution>
<!-- Run npm install -->
<!-- Install exact dependencies from package-lock.json -->

@PDavid PDavid Aug 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah nice improvement! 👍

@PDavid

PDavid commented Aug 4, 2026

Copy link
Copy Markdown
Contributor

There was a strange error in the CI build:

[INFO] ✓ built in 19.84s
[INFO] [MDX] generated files in 2.1230040000009467ms
[INFO] Error: Prerender: Request failed for /: connect ECONNREFUSED 127.0.0.1:41525
[INFO]     at defaultHandleError (file:///home/runner/work/hbase/hbase/src/hbase-website/node_modules/@react-router/dev/dist/vite.js:887:8)
[INFO]     at attempt (file:///home/runner/work/hbase/hbase/src/hbase-website/node_modules/@react-router/dev/dist/vite.js:835:11)
[INFO]     at process.processTicksAndRejections (node:internal/process/task_queues:104:5)
[INFO]     at async prerender (file:///home/runner/work/hbase/hbase/src/hbase-website/node_modules/@react-router/dev/dist/vite.js:842:64)
[INFO]     at async default.concurrency.concurrency (file:///home/runner/work/hbase/hbase/src/hbase-website/node_modules/@react-router/dev/dist/vite.js:859:9)
[INFO]     at async file:///home/runner/work/hbase/hbase/src/hbase-website/node_modules/p-map/index.js:121:20
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:11 min
[INFO] Finished at: 2026-08-04T11:11:02Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.1:npm (npm-run-ci) on project hbase-website: Failed to run task: 'npm run ci-skip-tests' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]

I'm now trying to rerun it to see if it was a one-off.

@yuriipalam

yuriipalam commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

There was a strange error in the CI build:

[INFO] ✓ built in 19.84s
[INFO] [MDX] generated files in 2.1230040000009467ms
[INFO] Error: Prerender: Request failed for /: connect ECONNREFUSED 127.0.0.1:41525
[INFO]     at defaultHandleError (file:///home/runner/work/hbase/hbase/src/hbase-website/node_modules/@react-router/dev/dist/vite.js:887:8)
[INFO]     at attempt (file:///home/runner/work/hbase/hbase/src/hbase-website/node_modules/@react-router/dev/dist/vite.js:835:11)
[INFO]     at process.processTicksAndRejections (node:internal/process/task_queues:104:5)
[INFO]     at async prerender (file:///home/runner/work/hbase/hbase/src/hbase-website/node_modules/@react-router/dev/dist/vite.js:842:64)
[INFO]     at async default.concurrency.concurrency (file:///home/runner/work/hbase/hbase/src/hbase-website/node_modules/@react-router/dev/dist/vite.js:859:9)
[INFO]     at async file:///home/runner/work/hbase/hbase/src/hbase-website/node_modules/p-map/index.js:121:20
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  01:11 min
[INFO] Finished at: 2026-08-04T11:11:02Z
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.1:npm (npm-run-ci) on project hbase-website: Failed to run task: 'npm run ci-skip-tests' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]

I'm now trying to rerun it to see if it was a one-off.

Doesn't seem to be app related, could be some system side effect or something

@yuriipalam

yuriipalam commented Aug 4, 2026

Copy link
Copy Markdown
Contributor Author

@PDavid the check was fine locally. Can we rerun it somehow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PDavid PDavid PDavid approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yuriipalam @PDavid