IGNITE-28882: window execution refactoring

[oleg-zinovev]

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

• There is a single JIRA ticket related to the pull request.
• The web-link to the pull request is attached to the JIRA ticket.
• The JIRA ticket has the Patch Available state.
• The pull request body describes changes that have been made.
  The description explains WHAT and WHY was made instead of HOW.
• The pull request title is treated as the final commit message.
  The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
• A reviewer has been mentioned through the JIRA comments
  (see the Maintainers list)
• The pull request has been checked by the Teamcity Bot and
  the green visa attached to the JIRA ticket (see tab PR Check at TC.Bot - Instance 1 or TC.Bot - Instance 2)

Notes

• How to Contribute
• Coding abbreviation rules
• Coding Guidelines
• Apache Ignite Teamcity Bot

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

[oleg-zinovev]

Hi,

I’d appreciate any feedback.

Do you think we should completely remove the BufferingWindowPartition and StreamingWindowPartition classes and move their functionality to BufferingWindowNode and StreamingWindowNode respectively?

[ignitetcbot]

TCBot Test Analysis

• TeamCity: --> Run :: All Results
• Branch: pull/13359/head
• Base: master
• Tested commit: 9cb79fc

Possible Blockers (6)

• Platform .NET (Windows) 3: 0 tests TIMEOUT , Exit Code
  • Timeout is a blocker. Base branch critical fail rate is 18,8% Exit Code is a blocker. Base branch fail rate is 76,3%
• Platform .NET (Windows): 0 tests TIMEOUT , Exit Code
  • Timeout is a blocker. Base branch critical fail rate is 12,7% Exit Code is a blocker. Base branch fail rate is 44,3%
• Queries 3: 1 tests
  • IgniteBinaryCacheQueryTestSuite3: IndexingCachePartitionLossPolicySelfTest.checkLostPartition[TRANSACTIONAL READ_ONLY_ALL 2 false 5 true] - Test has low fail rate in base branch 0,0% and is not flaky
• Basic 1: 1 tests
  • IgniteBasicTestSuite: CoreVersionRollingUpgradeTest.testClusterVersionUpgrade - Test has low fail rate in base branch 0,0% and is not flaky
• Platform C++ CMake (Win x64 | Release): 0 tests CANCELLED
  • Suite was cancelled, cancellation is always a blocker
• Snapshots 2: 1 tests
  • IgniteSnapshotTestSuite2: IgniteClusterSnapshotRestoreSelfTest.testCrdLeftDuringCacheStartOnExchangeFinish[encryption=false, onlyPrimay=false] - Test has low fail rate in base branch 0,0% and is not flaky

New Tests (0)

No new tests found.

[oleg-zinovev]

@alex-plekhanov
Hi

Could you help me out with how we usually request a review? I’m still getting the hang of the workflow here.

P.S.
Sorry for tagging you directly in the PR — I couldn’t find the right person’s name in Jira to add a comment, and I also didn’t manage to track down a template for the dev mail list. If you could just point me in the right direction or share a quick example, that’d be super helpful!

[alex-plekhanov]

@oleg-zinovev you can tag user here or in jira to request review (my username in jira is @alex_pl). I will have a look at this PR after vacation.