Reject database paths with empty nodes on ConfigNode#18308
Open
Caideyipi wants to merge 1 commit into
Open
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ConfigNode now validates every node in a database path before checking database conflicts. If any node is an empty string, the request is rejected with
ILLEGAL_PATHinstead of allowing an invalid path such asroot.or an empty table-model database name into ConfigNode metadata.The validation stays in
ClusterSchemaInfo.isDatabaseNameValid, so all database creation paths that go throughClusterSchemaManager, including pipe-generated plans, share the same guard.Unit coverage includes valid tree/table database names and empty nodes at the database, middle, and trailing levels.
Tests
mvn spotless:apply -pl iotdb-core/confignodemvn test -pl iotdb-core/confignode -Dtest=ClusterSchemaInfoTestmvn test-compile -pl iotdb-core/confignode -P with-zh-locale -DskipTestsThis PR has:
Key changed/added classes
ClusterSchemaInfoClusterSchemaInfoTest