Drop unused scala-collection-compat dependency - #7600
Open
bowenliang123 wants to merge 1 commit into
Open
Conversation
No source file in Kyuubi imports `scala.collection.compat.*`, and Iceberg 1.11.0 (current `iceberg.version`) no longer depends on this library for the Scala 2.12 path. The previous pin to 2.12.0 (commit 550f1fc, \apache#6677) was justified by Iceberg 1.6.1; that no longer applies. Spark SQL still brings in `scala-collection-compat_2.12` transitively at `provided` scope (verified via `mvn dependency:tree`), so the classpath behaviour is unchanged. Removing the explicit declaration lets Maven dependency mediation follow Spark's version instead of pinning an older 2.12.0. 3 hunks across 2 files: - pom.xml: `<scala-collection-compat.version>` property - pom.xml: dependencyManagement entry - extensions/spark/kyuubi-spark-authz/pom.xml: test-scope dependency Verified: `mvn -Pfast clean package -DskipTests -pl extensions/spark/kyuubi-spark-authz -am` passes.
bowenliang123
force-pushed
the
drop-scala-collection-compat
branch
from
July 30, 2026 06:49
ce53ba8 to
1645dca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
scala-collection-compatis no longer used anywhere in Kyuubi:grep -rn 'import scala.collection.compat' --include='*.scala'returns zero hits across the entire repo.1.11.0(currenticeberg.versionperpom.xml:167) no longer shipsscala-collection-compatin its runtime jar; checkediceberg-spark-runtime-3.5_2.12-1.11.0.jarand thescala/collection/compatpackage is absent.550f1fce8, Bump scala-collection-compat to 2.12.0 #6677) was that Iceberg 1.6.1 transitively pulledscala-collection-compat:2.12.0. Iceberg has since moved on.pom.xml:124<scala-collection-compat.version>lives outside any profile, so bothscala-2.12andscala-2.13(lines 2003/2011) shared the same pin. Neither path needs it.3 hunks across 2 files:
pom.xml: drop<scala-collection-compat.version>propertypom.xml: drop the corresponding<dependencyManagement>entryextensions/spark/kyuubi-spark-authz/pom.xml: drop the<scope>test</scope>dependencyHow was this patch tested?
mvn -Pfast clean package -DskipTests -pl extensions/spark/kyuubi-spark-authz -am— 7 modules build cleanly (kyuubi-parent, kyuubi-util, kyuubi-util-scala, kyuubi-common, kyuubi-events, kyuubi-spark-lineage, kyuubi-spark-authz)mvn -pl extensions/spark/kyuubi-spark-authz dependency:treeconfirmsscala-collection-compat_2.12:2.7.0still lands on the classpath transitively (via Spark SQLprovidedscope) — classpath behaviour unchanged, just let Maven dependency mediation pick the version Spark wants instead of pinning an older 2.12.0mvn testto follow before mergeWas this patch authored or co-authored using generative AI tooling?
Yes.
Assisted-by: OpenCode with MiniMax-M3