[core] Refactor sort compact to produce COMPACT commits#8571
Closed
hbgstc123 wants to merge 5 commits into
Closed
Conversation
hbgstc123
force-pushed
the
fix_sort_compact
branch
2 times, most recently
from
July 12, 2026 10:40
17267f4 to
17d1a07
Compare
Co-authored-by: Cursor <cursoragent@cursor.com>
Pass the real table schema into KeyValueTableRead in test helpers so keyValueSequenceNumberEnabled() can read schema options without NPE. Co-authored-by: Cursor <cursoragent@cursor.com>
hbgstc123
force-pushed
the
fix_sort_compact
branch
from
July 12, 2026 12:42
659e4ac to
6fb4bf8
Compare
Only emit delete-only compact commits at job end, use restore-only state for dynamic-bucket sort compact, and compact test data before checking raw-convertible splits. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
What is your requirement? Is it just an Append table? Can we remove the primary key table? I haven't seen it used before. |
Author
|
append table only is ok. I will new PR only support append table |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Status
Closed in favor of #8631.
Per review feedback, the follow-up PR narrows scope to append tables only and drops primary-key / dynamic-bucket sort compact support from this change. #8631 also adds DV cleanup hardening and Flink commit failure handling on top of the COMPACT-commit refactor below.
Purpose
Follow up on #7595 per this review comment: sort compact should not be modeled as an OVERWRITE commit with extra base-snapshot handling. Instead, it should produce a normal COMPACT commit so the existing commit protocol can perform compact validation and conflict detection.
This PR fixes the concurrent-write data loss risk in sort compact by refactoring Flink/Spark sort compact for append tables to:
No new overwritePartition(baseSnapshotId) APIs or special overwrite conflict logic are introduced.
Tests
Core
Flink
Spark