[spark] Fix flaky SparkMultimodalITCase by binding its test metastore to a free port#8833
Closed
XiaoHongbo-Hope wants to merge 1 commit into
Closed
Conversation
SparkMultimodalITCase hardcodes port 9092 (also Kafka's default) for its test Hive metastore, so TestHiveMetastore.start(9092) intermittently fails with "Cannot start TestHiveMetastore" when the port is already taken -- currently flaky on master too. Start the metastore on port 0 (an OS-assigned free port) and read the actual port back via a new TestHiveMetastore.getPort() for the Spark configs.
XiaoHongbo-Hope
changed the title
Contributor
|
Duplicated to #8820 ? |
Contributor
Author
ok |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
SparkMultimodalITCasehardcodes port9092(which is also Kafka's default port) for its test Hive metastore, soTestHiveMetastore.start(9092)intermittently fails when the port is already taken:This is currently flaky on master too (e.g. the
UTCase and ITCase Spark 4.xjob fails on several recent master pushes with the exact same error).Start the metastore on port
0(an OS-assigned free port, whichTestHiveMetastorealready resolves viagetLocalPort()) and read the actual port back through a newTestHiveMetastore.getPort()for the Spark configs, so the test no longer depends on a fixed port being free.Tests
Exercised by
SparkMultimodalITCaseitself; the fixed-port race can't be reproduced deterministically in a unit test.