#1998 WARC writer: WARC-Protocol header to follow WARC field proposals - #2034
Open
sebastian-nagel wants to merge 1 commit into
Open
#1998 WARC writer: WARC-Protocol header to follow WARC field proposals#2034sebastian-nagel wants to merge 1 commit into
sebastian-nagel wants to merge 1 commit into
Conversation
(fixes apache#1998) OkHttp protocol: add protocol response header key `_cipher_suites_` to hold the SSL/TLS Cipher suite separate from `_protocol_versions_`. WARC writer: 1. add WARC header `WARC-Cipher-Suite` 2. split multiple values in `WARC-Protocol` header and repeat header
jnioche
reviewed
Jul 30, 2026
| .header(ProtocolResponse.RESPONSE_IP_KEY, ipAddress) | ||
| .header(ProtocolResponse.REQUEST_TIME_KEY, Long.toString(startFetchTime)) | ||
| .header(ProtocolResponse.PROTOCOL_VERSIONS_KEY, protocols.toString()) | ||
| .header(ProtocolResponse.CIPHER_SUITES_KEY, cipherSuite) |
Contributor
There was a problem hiding this comment.
what happens if cipherSuite is null?
Contributor
Author
There was a problem hiding this comment.
WARC writer checks for null anyway, because another protocol implementation could have been used which does not collect the necessary information. If it's not available, it does not add the WARC-Cipher-Suite header.
But I can change the code, so that no header is added, if no Cipher suite was used (connection over http://).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #1998.
OkHttp protocol:
_cipher_suites_to hold the SSL/TLS Cipher suite separate from_protocol_versions_.WARC writer:
WARC-Cipher-SuiteWARC-Protocolheader and repeat headerExample WARC header with this change applied: