Skip to content

[ZEPPELIN-6548] Use specific exceptions for Spark Scala fallback detection #5340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
miinhho wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −3
Open

[ZEPPELIN-6548] Use specific exceptions for Spark Scala fallback detection #5340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...rver/src/main/java/org/apache/zeppelin/interpreter/launcher/SparkInterpreterLauncher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,10 +318,10 @@ private String detectSparkScalaVersionByReplClass(String sparkHome) throws Excep
}

if (sparkReplJars.isEmpty()) {
throw new Exception("No spark-repl jar found in SPARK_HOME: " + sparkHome);
throw new IOException("No spark-repl jar found in SPARK_HOME: " + sparkHome);
}
if (sparkReplJars.size() > 1) {
throw new Exception("Multiple spark-repl jar found in SPARK_HOME: " + sparkHome);
throw new IOException("Multiple spark-repl jar found in SPARK_HOME: " + sparkHome);
}

String fileName = sparkReplJars.get(0).getFileName().toString();
Expand All @@ -330,7 +330,7 @@ private String detectSparkScalaVersionByReplClass(String sparkHome) throws Excep
} else if (fileName.contains("spark-repl_2.13")) {
return "2.13";
} else {
throw new Exception("Can not detect the scala version by spark-repl");
throw new IllegalArgumentException("Can not detect the scala version by spark-repl");
}
}

Expand Down
Loading