fix(serve): propagate additional_model_data_sources for JumpStart models - #6151
Open
e-davidson wants to merge 1 commit into
Open
fix(serve): propagate additional_model_data_sources for JumpStart models#6151e-davidson wants to merge 1 commit into
e-davidson wants to merge 1 commit into
Conversation
ModelBuilder._build_for_jumpstart() copied image_uri, env, enable_network_isolation, model_reference_arn, and model_data from the resolved JumpStart init_kwargs, but never propagated additional_model_data_sources. Any JumpStart model whose spec declares an extra S3 data channel (e.g. an EAGLE speculative decoding draft model, a LoRA adapter, or a tokenizer override) therefore had that channel silently dropped from the CreateModel call, and the container failed at runtime trying to read artifacts from a path that was never mounted. Propagate additional_model_data_sources from init_kwargs onto the builder so _prepare_container_def_base attaches it to the CreateModel request. Each source is filtered to only the keys the CreateModel API accepts (ChannelName, S3DataSource); JumpStart specs may include extra metadata keys such as HostingEulaKey that the API rejects. Adds unit tests for both the propagation+filtering path and the no-op case when the spec declares no additional data sources.
e-davidson
requested a deployment
to
manual-approval
August 4, 2026 01:46 — with
GitHub Actions
Waiting
e-davidson
requested a deployment
to
manual-approval
August 4, 2026 01:46 — with
GitHub Actions
Waiting
e-davidson
requested a deployment
to
manual-approval
August 4, 2026 01:46 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ModelBuilder._build_for_jumpstart() copied image_uri, env,
enable_network_isolation, model_reference_arn, and model_data from the
resolved JumpStart init_kwargs, but never propagated
additional_model_data_sources. Any JumpStart model whose spec declares
an extra S3 data channel (e.g. an EAGLE speculative decoding draft
model, a LoRA adapter, or a tokenizer override) therefore had that
channel silently dropped from the CreateModel call, and the container
failed at runtime trying to read artifacts from a path that was never
mounted.
Propagate additional_model_data_sources from init_kwargs onto the
builder so _prepare_container_def_base attaches it to the CreateModel
request. Each source is filtered to only the keys the CreateModel API
accepts (ChannelName, S3DataSource); JumpStart specs may include extra
metadata keys such as HostingEulaKey that the API rejects.
Adds unit tests for both the propagation+filtering path and the no-op
case when the spec declares no additional data sources.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.