Skip to content

fix: configure initial certificate roles - #62

Merged
leopoldjoy merged 1 commit into
mainfrom
audit/configure-initial-admin-roles
Jul 31, 2026
Merged

fix: configure initial certificate roles#62
leopoldjoy merged 1 commit into
mainfrom
audit/configure-initial-admin-roles

Conversation

@leopoldjoy

Copy link
Copy Markdown
Contributor

Summary

  • accept initial owner and revoker addresses in the CertManager constructor
  • reject zero role addresses and emit initialization events for the configured roles
  • update deployment docs, changelog, tests, and demo/test deployments

Audit finding

Addresses external finding #18.

Tests

  • forge fmt --check src test script
  • forge test (205 passed, 1 skipped)
  • production CertManager runtime remains within EIP-170

Co-authored-by: OpenCode <opencode-noreply@coinbase.com>
@leopoldjoy
leopoldjoy marked this pull request as ready for review July 27, 2026 13:41
@leopoldjoy
leopoldjoy merged commit 91ba3d7 into main Jul 31, 2026
8 checks passed
@leopoldjoy
leopoldjoy deleted the audit/configure-initial-admin-roles branch July 31, 2026 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants