Feat/web fixes - #261
Open
diocas wants to merge 4 commits into
Open
Conversation
The invite-collaborator search box now recognizes a pasted block of emails - "jane@x.com, john@x.com", "Jane <jane@x.com>; John <john@x.com>", newline separated, or any mix of those - extracts just the addresses, and looks up each one automatically instead of treating the whole paste as one literal search term. Matches get selected right away; the search box is disabled and shows the existing loading spinner while the lookups are in flight, and an error message reports any addresses that couldn't be matched to a user. A single, plain-typed query (e.g. "jane") still goes through the normal live-search/autocomplete flow unchanged.
Lets consumers embed content (e.g. a chip/dropdown) inside the input's box, next to the clear button, without forking the component.
FilePickerModal was hardcoded to open the picked resource in a new tab with a different app (its only consumer, useFileActionsOpenWithApp). Swap its `app` prop for `allowedFileTypes`/`callbackFn`, and move the route-resolution/window.open logic that used to live in the component into useFileActionsOpenWithApp's own callback, so the modal becomes a generic "pick a resource, hand it back to me" primitive. Needed so web-app-external's upcoming insert-graphic/insert-file/insert-link common functions can reuse this modal instead of duplicating it.
…al candidates Instead of a separate app-picker step before the filename dialog, the "Create a new file" dialog now shows a dropdown to switch apps inline, defaulting to the priority app, when several apps can open the chosen extension.
rawe0
approved these changes
Jul 28, 2026
rawe0
left a comment
rawe0
left a comment
There was a problem hiding this comment.
Looks good if we can understand why we get the 502 from the gateway when testing.
| } | ||
|
|
||
| return emails.length > 1 || emails[0].toLowerCase() !== query.trim().toLowerCase() | ||
| } |
There was a problem hiding this comment.
There's a case missing here when email.length === 1? (may be intended? just results in a normal search)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Usability fixes: