Replace QDox with JavaParser - #225
Open
wilx wants to merge 1 commit into
Open
Conversation
Parse module-info.java directly instead of registering its source directory with QDox. This avoids parsing referenced service implementations while collecting JPMS directives and supports current Java syntax. Fixes apache/maven-compiler-plugin#314
wilx
marked this pull request as ready for review
July 28, 2026 13:48
Author
|
@slachiewicz Please review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
module-info.javainstead of registering the complete source directoryMotivation
SourceModuleInfoParserregistered the descriptor's parent directory with QDox. Resolvingusesandprovidesdirectives could then parse referenced service sources and reject valid annotated types before the Java compiler was invoked. Reading the directive names directly from themodule-info.javaAST avoids that unrelated source traversal.QDox is end-of-life; see the Status section in its README.
Testing
JAVA_HOME=/opt/jdks/latest-21 /opt/maven/latest/bin/mvn verify— 79 unit tests and 4 integration tests passedJAVA_HOME=/opt/jdks/latest-8 /opt/maven/latest/bin/mvn -pl plexus-java test— passed with 4 JDK-specific skipsjavac --release 9