fix: report the real layer count in the skip message - #24
Merged
Conversation
The skip path logged "5 identical layers" for a 4-layer image. layers() ends with `tr '\n' ','`, leaving a trailing comma, so `wc -l` counts a phantom empty line. Cosmetic — the comparison itself is unaffected, since both sides carry the same trailing comma — but a shared workflow that prints a number contradicting the image will send someone chasing a discrepancy that does not exist. Verified against the live manifest: wc -l says 5, grep -c says 4, the image has 4. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caught on the first real run of #23, from
cshuttle/nmon:The image has 4 layers.
layers()ends withtr '\n' ',', leaving a trailing comma, sowc -lcounts a phantom empty line.Cosmetic — the comparison is unaffected, because both sides carry the same trailing comma, and the run correctly took the skip path. But a shared workflow printing a number that contradicts the image will send someone chasing a discrepancy that doesn't exist, and this repo is the supply-chain root for every consumer.
Verified against the live manifest:
wc -l→ 5,grep -c .→ 4, actual → 4.🤖 Generated with Claude Code