Skip to content

pstack: cut model-config prose to its definition sites#167

Merged
poteto merged 2 commits into
mainfrom
benny/pstack-model-config-minimum-e454
Jul 23, 2026
Merged

pstack: cut model-config prose to its definition sites#167
poteto merged 2 commits into
mainfrom
benny/pstack-model-config-minimum-e454

Conversation

@poteto

@poteto poteto commented Jul 23, 2026

Copy link
Copy Markdown
Collaborator

What

Model routing behavior is unchanged; the prose shrinks to the places that define it.

  • setup-pstack keeps the inherit-parent / auto definition (steps 1, 3, 4) and writes it into the generated rule's header comment; the five-line resolution block collapses to one definition line.
  • poteto-mode keeps one alias clause at the end of the Task-call defaults paragraph.
  • how, why, arena, architect, reflect, and interrogate drop their per-call-site resolution instructions ("pass a real slug / omit model for inherit-parent/auto / if the role line is absent...") and return to compact configured-role pointers. All current model defaults stay exactly as they are.
  • interrogate gains configurable reviewer counts: the interrogate reviewers list sets the panel size, the Reviewer A/B/C labels extend or shrink to the configured entry count, and a default table keeps the current panel.

Why

Call-mechanics instructions in skill prose do not change agent behavior; the subagent tool schema (model optional, omitted inherits the parent) governs. Prose that defines what a config value means is what earns its place. Verified with blinded behavioral runs on this tree: a mixed config planted (aliases on panel roles, real slugs elsewhere, one role line deleted), multiple parent model families, spawn calls graded mechanically from transcripts. One blinded run showed a config-misread unrelated to this change (that agent never opened the skill file this change edits for that path); the fan-out and alias invariants held across all runs.

Version

0.11.7 -> 0.11.8 (skill-content change, per repo convention).

Open in Web Open in Cursor 

Keep the inherit-parent/auto definition in setup-pstack (steps 1/3/4 and
the generated rule's header comment) and one poteto-mode clause; drop the
per-call-site resolution instructions from how, why, arena, architect,
reflect, and interrogate, restoring the compact configured-role pointers
with the current defaults. Make interrogate reviewer counts configurable:
the interrogate reviewers list sets the panel size and the Reviewer A/B/C
labels extend or shrink to the entry count. Bump 0.11.7 -> 0.11.8.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Interrogate drops alias spawn guard
    • Restored the instruction to omit model for alias entries and exclude those aliases from slug fallback handling.

Create PR

Or push these changes by commenting:

@cursor push 86e3420fe6
Preview (86e3420fe6)
diff --git a/pstack/skills/interrogate/SKILL.md b/pstack/skills/interrogate/SKILL.md
--- a/pstack/skills/interrogate/SKILL.md
+++ b/pstack/skills/interrogate/SKILL.md
@@ -43,10 +43,10 @@
 
 For each reviewer:
 - `subagent_type`: `generalPurpose`
-- `model`: the configured `interrogate reviewers` entry, or the table default with no configured line
+- `model`: the configured `interrogate reviewers` entry, or the table default with no configured line; omit `model` for `inherit-parent` or `auto`
 - `readonly`: `true`
 
-If a model slug is rejected as unresolvable when you try to spawn the subagent, check the valid slugs in the Task tool's error message, pick the closest equivalent (prefer the highest-reasoning tier of the same family), spawn with the valid slug, and open a separate PR to update the configured value or default table. Do not block the review on the slug issue.
+If a real model slug is rejected as unresolvable when you try to spawn the subagent, check the valid slugs in the Task tool's error message, pick the closest equivalent (prefer the highest-reasoning tier of the same family), spawn with the valid slug, and open a separate PR to update the configured value or default table. Do not block the review on the slug issue. Never treat `inherit-parent` or `auto` as model slugs or enter this fallback for them.
 
 Read `references/reviewer-prompt.md` and fill in the template with:
 1. The stated intent

You can send follow-ups to the cloud agent here.

Reviewed by Cursor Bugbot for commit f3fc065. Configure here.

Comment thread pstack/skills/interrogate/SKILL.md Outdated
Co-authored-by: lauren <poteto@users.noreply.github.com>
@poteto
poteto marked this pull request as ready for review July 23, 2026 22:11
@poteto
poteto merged commit 04166ac into main Jul 23, 2026
2 checks passed
github-actions Bot added a commit to SmailG/claude-cursor-plugins that referenced this pull request Jul 24, 2026
…ts definition sites (cursor#167)

chore: sync with cursor/plugins — pstack: cut model-config prose to its definition sites (cursor#167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant