Provide Struct data type support for oracle plugin - #659
Open
vanshikaagupta22 wants to merge 9 commits into
Open
Provide Struct data type support for oracle plugin#659vanshikaagupta22 wants to merge 9 commits into
vanshikaagupta22 wants to merge 9 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for resolving Oracle STRUCT types into CDAP RECORD schemas by querying the ALL_TYPE_ATTRS metadata table. The implementation includes recursive resolution for nested structures and an updated mapping for primitive Oracle types. Feedback highlights several critical issues: the metadata query lacks an OWNER filter which could lead to incorrect schema resolution in multi-schema environments; fully qualified type names containing dots will cause IllegalArgumentException when creating CDAP records; and there are logic errors in the primitive type mapping, specifically regarding Oracle-specific type naming conventions and an invalid comparison between Java class names and SQL type strings.
vanshikaagupta22
force-pushed
the
oracle-structsupport
branch
from
May 6, 2026 14:13
a88c6b7 to
231c6ee
Compare
vanshikaagupta22
force-pushed
the
oracle-structsupport
branch
from
May 21, 2026 12:23
e6834e3 to
fe03c7b
Compare
# Conflicts: # oracle-plugin/src/main/java/io/cdap/plugin/oracle/OracleSourceSchemaReader.java # oracle-plugin/src/test/java/io/cdap/plugin/oracle/OracleSchemaReaderTest.java
vishwasvaidya-cloudsufi
force-pushed
the
oracle-structsupport
branch
2 times, most recently
from
June 15, 2026 10:01
a11f5cc to
af67d36
Compare
vishwasvaidya-cloudsufi
force-pushed
the
oracle-structsupport
branch
from
June 17, 2026 06:11
af67d36 to
3bfd8ba
Compare
vanshikaagupta22
force-pushed
the
oracle-structsupport
branch
from
June 19, 2026 10:27
f4ab512 to
47834bb
Compare
vanshikaagupta22
force-pushed
the
oracle-structsupport
branch
from
June 19, 2026 10:53
47834bb to
219b85e
Compare
| recordBuilder.set(field.getName(), bigDecimal.longValue()); | ||
| break; | ||
| case STRING: | ||
| recordBuilder.set(field.getName(), bigDecimal.toString()); |
vanshikaagupta22
force-pushed
the
oracle-structsupport
branch
3 times, most recently
from
July 15, 2026 14:43
3455570 to
7495c92
Compare
Sunish-Dahiya
requested changes
Jul 27, 2026
| Object[] attributes = struct.getAttributes(); | ||
| if (attributes != null) { | ||
| try { | ||
| Object descriptor = struct.getClass().getMethod("getDescriptor").invoke(struct); |
Contributor
Author
There was a problem hiding this comment.
We use reflection to extract column names via getDescriptor() without adding a compile-time dependency on ojdbc (which is provided at runtime).
vanshikaagupta22
force-pushed
the
oracle-structsupport
branch
from
July 27, 2026 12:43
7495c92 to
046c0be
Compare
vanshikaagupta22
force-pushed
the
oracle-structsupport
branch
from
July 27, 2026 13:25
046c0be to
d24127c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds native support for resolving Oracle STRUCT types (Object Types) into CDAP RECORD schemas. By querying the ALL_TYPE_ATTRS metadata table, the schema builder dynamically processes complex structures with support for up to 4 levels of nesting. Internal attributes are first translated to standard SQL data types via a dedicated mapper before being converted into the final CDAP schema.
When reading the data, the implementation overrides the setField() function, providing a custom implementation to properly extract and map individual custom object attributes according to requirements.
Note: Users will require explicit EXECUTE privileges on the custom Oracle object types to successfully resolve the schema.