Add -Wconversion and -Wsign-conversion to extra warning level flags - #9321
Closed
earlephilhower with Copilot wants to merge 2 commits into
Closed
Add -Wconversion and -Wsign-conversion to extra warning level flags#9321earlephilhower with Copilot wants to merge 2 commits into
earlephilhower with Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix warnings introduced with -Wconversion and -Wsign-conversion
Add -Wconversion and -Wsign-conversion to extra warning level flags
Jul 29, 2026
earlephilhower
approved these changes
Jul 29, 2026
earlephilhower
left a comment
earlephilhower
left a comment
Collaborator
There was a problem hiding this comment.
Change will add warning flags but not fix any of the generated warnings
Collaborator
|
Burned thousands of kWh and didn't really do anything. Sorry, planet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables
-Wconversionand-Wsign-conversionat the "All" (extra) warning level, as raised in #9318. These flags surface implicit narrowing and sign-change conversions that are currently silent under-Wall -Wextra.Changes
tools/warnings/extra-cflags— appended-Wconversion -Wsign-conversiontools/warnings/extra-cxxflags— appended-Wconversion -Wsign-conversionThese files are used when the IDE warning level is set to All, and are also pulled in by the CI build via
platform.local.txt. Lower warning levels (default,more,none) are unaffected.