sample(app): add Firestore, Database & Storage demos to sample app#2406
sample(app): add Firestore, Database & Storage demos to sample app#2406demolaf wants to merge 21 commits into
Conversation
…stUtils in paging test
…instance and add unit tests
…2383) * fix(auth): validate display name only when required in sign-up form * fix(auth): use locale-safe matcher for sign-up button in test
# Conflicts: # app/src/main/AndroidManifest.xml # app/src/main/java/com/firebaseui/android/demo/MainActivity.kt # app/src/main/java/com/firebaseui/android/demo/auth/HighLevelApiDemoActivity.kt # storage/build.gradle.kts
There was a problem hiding this comment.
Code Review
This pull request restructures the demo application by modularizing the Auth demos and introducing new demonstration activities for Firebase Realtime Database, Firestore, and Storage (using Glide). It also updates FirestorePagingSource to properly handle InterruptedException and avoid undeliverable RxJava exceptions. Feedback focuses on several key improvements: configuring and initializing the Realtime Database emulator, exposing and passing the emulator mode to the Auth chooser screen, resolving a bug in the Storage demo where Glide loads are triggered on every keystroke, programmatically converting dp to pixels for view holder padding to avoid raw pixel anti-patterns, and optimizing Firestore data seeding using a WriteBatch.
d382bd5 to
1ecd498
Compare
Adds demo activities for Realtime Database, Firestore, and Storage to the sample app.
auth/subpackage; adddatabase/,firestore/,storage/subpackagesDatabaseDemoActivity— paginated list viaFirebaseRecyclerPagingAdapter+orderByChildFirestoreDemoActivity— paginated list viaFirestorePagingAdapter+orderBy, seeded with aWriteBatchStorageDemoActivity— loadsgs://URLs via Glide, both as a raw string (StringLoader) and viaStorageReferenceMainActivityPreview
sample-demo.webm