fix: correct telemetry span nesting and lifecycle - #2561
Merged
Conversation
- log limit reached without the exception stacktrace - track nested loading/transformation spans on a stack - stop LimitReachedException from escaping TransformerLoader - expand to_transformation() once per loader, not per batch
…ation - span() no longer activates the span; activate() returns a detachable Scope - parent argument is a full Context and is forwarded to the sampler - complete() ends once instead of re-exporting, and no longer detaches - detach() reports out-of-order and already-detached scopes - stop activating stream, cursor and bucket spans so concurrent ones stay siblings - close bucket source streams so their spans complete
norberttech
force-pushed
the
limit-exception-noise
branch
from
July 28, 2026 15:50
43ef139 to
7aae7be
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2561 +/- ##
============================================
+ Coverage 86.41% 86.44% +0.02%
- Complexity 23299 23516 +217
============================================
Files 1800 1803 +3
Lines 71260 71434 +174
============================================
+ Hits 61581 61748 +167
- Misses 9679 9686 +7 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
flow-php/telemetry-Tracer::activate()returning a detachableScopeflow-php/telemetry-Scope::DETACHED,Scope::INACTIVEandScope::MISMATCHdetach resultsflow-php/etl-FloeStreamReader::close()Fixed
flow-php/filesystem- concurrently open stream spans no longer nest into each otherflow-php/etl- bucket source streams are closed, so their spans completeflow-php/telemetry- the sampler receives the parentContextinstead of the ambient oneflow-php/telemetry-Tracer::complete()no longer re-exports a span when called twiceflow-php/etl-LimitReachedExceptionno longer escapesto_transformation()flow-php/etl- limit reached is logged without the exception stacktraceChanged
flow-php/telemetry-Tracer::span()no longer makes the span currentflow-php/telemetry-Tracer::span()andtrace()take aContextparent instead of aSpanContextflow-php/telemetry-Tracer::complete()no longer detaches the scopeflow-php/etl-to_transformation()expands aTransformationonce per loader, not per batchflow-php/etl- nested loading and transformation spans are tracked on a stackflow-php/phpunit-telemetry-bridge-SpanStack::push()takes the span scopeRemoved
flow-php/telemetry-Span::contextScope()andSpan::setContextScope()flow-php/telemetry-MemoryContextStorage::store()Deprecated
Security