refactor(flow-php/symfony-postgresql-bundle): own the profiler client - #2571
Merged
Conversation
- move RecordingClient, QueryLog, QueryLogOptions and RecordedQuery out of flow-php/postgresql as ProfilerClient, QueryRecorder, QueryRecorderOptions - register the panel only in debug mode, so --no-debug records nothing - bound retained statements with profiler.max_query_length - rename profiler.max_parameters to max_retained_parameters - mark truncated statements in the panel and exclude them from EXPLAIN
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2571 +/- ##
============================================
- Coverage 86.51% 86.27% -0.24%
- Complexity 23235 23661 +426
============================================
Files 1812 1816 +4
Lines 71549 71840 +291
============================================
+ Hits 61898 61981 +83
- Misses 9651 9859 +208 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
flow-php/symfony-postgresql-bundle-profiler.max_query_lengthoption bounding retained statementsflow-php/symfony-postgresql-bundle- panel marks truncated statements and excludes them from EXPLAINFixed
flow-php/symfony-postgresql-bundle- long running console commands no longer retain queries for a panel that never rendersChanged
flow-php/symfony-postgresql-bundle- query recording moved fromflow-php/postgresqlasProfilerClient,QueryRecorderandQueryRecorderOptionsflow-php/symfony-postgresql-bundle- profiler registers only when the kernel runs in debug mode, so--no-debugrecords nothingflow-php/symfony-postgresql-bundle-profiler.max_parametersrenamed toprofiler.max_retained_parametersflow-php/symfony-postgresql-bundle- serviceflow.postgresql.profiler.query_logrenamed toflow.postgresql.profiler.query_recorderRemoved
flow-php/postgresql-Client\Debugnamespace withRecordingClient,QueryLog,QueryLogOptionsandRecordedQueryDeprecated
Security