Skip to content

fix: Remove broken Spotlight stuff from dev - #18862

Merged
BYK merged 3 commits into
masterfrom
byk/fix/bye-spotlight-sidecar
Jul 29, 2026
Merged

fix: Remove broken Spotlight stuff from dev#18862
BYK merged 3 commits into
masterfrom
byk/fix/bye-spotlight-sidecar

Conversation

@BYK

@BYK BYK commented Jul 29, 2026

Copy link
Copy Markdown
Member

No description provided.

@BYK
BYK requested review from chargome and sergical July 29, 2026 12:26
@vercel

vercel Bot commented Jul 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
develop-docs Ready Ready Preview Jul 29, 2026 12:43pm
sentry-docs Ready Ready Preview Jul 29, 2026 12:43pm

Request Review

@BYK
BYK enabled auto-merge (squash) July 29, 2026 12:27
@BYK BYK added the jared label Jul 29, 2026
@BYK

BYK commented Jul 29, 2026

Copy link
Copy Markdown
Member Author

Jared, fix the lockfile please

Comment thread package.json
Comment thread package.json
The dependency was removed from package.json but the import and
Spotlight.init() call in instrumentation-client.ts and the
pnpm-lock.yaml entries were left behind, breaking the build and
--frozen-lockfile CI installs.
@jared-outpost

jared-outpost Bot commented Jul 29, 2026

Copy link
Copy Markdown

Done in efe37db — the leftover @spotlightjs/spotlight entries are out of pnpm-lock.yaml (verified with pnpm install --frozen-lockfile), and I also removed the dangling import + Spotlight.init() call in src/instrumentation-client.ts that would've broken the build.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit efe37db. Configure here.

Comment thread package.json
The dev sidecar was removed from the `dev` script, so streaming to
localhost:8969 via spotlight just hits a dead endpoint. Remove the
spotlight option from server Sentry.init to match.
@BYK
BYK merged commit ef98a42 into master Jul 29, 2026
25 checks passed
@BYK
BYK deleted the byk/fix/bye-spotlight-sidecar branch July 29, 2026 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants