Revert "feat(homepage): Bifurcated homepage refresh" - #18870
Conversation
This reverts commit e368094.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit afde0dd. Configure here.
| ,{' '} | ||
| <Link href="/product/drains/" className="text-[#8b5cf6] underline"> | ||
| Logs | ||
| </Link> |
There was a problem hiding this comment.
Wrong Logs product link
Medium Severity
The homepage feature list labels this link as Logs, but href points to /product/drains/ (Log and Trace Drains) instead of /product/logs/. Visitors expecting Logs docs land on a different product page.
Reviewed by Cursor Bugbot for commit afde0dd. Configure here.
| <div className="w-full relative hero-gradient"> | ||
| {/* Single decorative squiggle at top right */} | ||
| <img | ||
| src={SquiggleSVG.src} |
There was a problem hiding this comment.
Bug: The code accesses SquiggleSVG.src directly. If the SVG is imported as a string URL instead of an object, .src will be undefined, causing a broken image.
Severity: LOW
Suggested Fix
To prevent a broken image, update the img tag to handle cases where the SVG is imported as a string. Use a defensive check like src={typeof SquiggleSVG === 'string' ? SquiggleSVG : SquiggleSVG?.src} to ensure the image source is always a valid string.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: src/components/home.tsx#L67
Potential issue: The `img` tag at `src/components/home.tsx:67` uses `SquiggleSVG.src` as
its source. This assumes the `SquiggleSVG` import is an object with a `.src` property.
However, depending on the Next.js configuration, SVG imports can resolve to a simple
string URL. In that scenario, attempting to access the `.src` property of a string
results in `undefined`, which will cause the image to fail to load. The codebase already
contains a safer pattern for this in `platformIcon.tsx`, which handles both string and
object imports: `typeof svg === 'string' ? svg : svg?.src`.
Also affects:
src/components/home.tsx:17~17
Did we get this right? 👍 / 👎 to inform future reviews.
…acking (#18864) ## DESCRIBE YOUR PR Reapplies the homepage refresh (#18786, reverted in #18870 to keep master clean while this iterated) and adds the follow-ups below, plus three bugs found along the way. - Homepage lists every SDK via the same `<PlatformFilter />` as `/platforms/`. - AI setup card is a click-to-copy `npx @sentry/ai install` pill with agent glyphs. - Homepage search removed in favour of the header one, which is on every other page already. - **Fix: Algolia click tracking recorded 0 clicks against 16,743 searches/week.** #10032 moved the Insights credentials to `NEXT_PUBLIC_ALGOLIA_SEARCH_KEY`, whose value 401s against the app the searches run in. Events now report a non-2xx instead of discarding it. The Vercel value has been corrected. - Fix: search dropdown inherited `text-align: center` and overran the viewport; it now caps to the space the input has and flips above only when that side is bigger. - Fix: duplicate sidebar separator on SDK pages. - Fix: `/platforms/` couldn't scroll — the selector auto-opened and Radix Select locks body scroll. - Homepage CSS into `home.module.scss`; icons from `react-feather`. Also drops the Algolia env references in `algolia-index.yml` — neither name exists as a repo or org secret, so they have resolved to empty strings since #10032. The Preview env scope is deliberately unset: Insights events carry no environment dimension, so preview clicks would land in production analytics. ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [ ] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>


Reverts #18786