Skip to content

test: Remove unnecessary test waits#22383

Merged
isaacs merged 1 commit into
developfrom
fn/remove-test-waits
Jul 20, 2026
Merged

test: Remove unnecessary test waits#22383
isaacs merged 1 commit into
developfrom
fn/remove-test-waits

Conversation

@mydea

@mydea mydea commented Jul 20, 2026

Copy link
Copy Markdown
Member

Removes the await Promise.resolve() microtick yields at the start of the ioredis, mysql2 and redis diagnostics-channel tracing scenarios.

These were added to give the DC subscriber a chance to register before the driver created/published on its native TracingChannels. With the orchestrion instrumentation now reliably wiring up channel subscribers before the instrumented module publishes, the manual yield is no longer needed and the scenarios are simpler without it.

@mydea
mydea marked this pull request as ready for review July 20, 2026 11:48
@mydea
mydea requested a review from a team as a code owner July 20, 2026 11:48
@mydea
mydea requested review from andreiborza and isaacs and removed request for a team July 20, 2026 11:48
@isaacs
isaacs merged commit d092fd4 into develop Jul 20, 2026
57 checks passed
@isaacs
isaacs deleted the fn/remove-test-waits branch July 20, 2026 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants