fix: skip empty patterns in match_regex_list to prevent IndexError#6842
Open
mangodxd wants to merge 1 commit into
Open
fix: skip empty patterns in match_regex_list to prevent IndexError#6842mangodxd wants to merge 1 commit into
mangodxd wants to merge 1 commit into
Conversation
match_regex_list indexes item_matcher[-1] to check for '$' suffix. An empty string pattern causes IndexError: string index out of range. This is reachable from CeleryIntegration.exclude_beat_tasks when user configures an empty string in the pattern list. Guard with if not item_matcher: continue before the index check. Fixes getsentry#6504
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6504
match_regex_listindexesitem_matcher[-1]to check for$suffix. When the pattern list contains an empty string,""[-1]raisesIndexError: string index out of range.This is reachable from
CeleryIntegration.exclude_beat_taskswhen user configures an empty string in the pattern list.Skip empty patterns with
if not item_matcher: continuebefore the index check. Empty strings cannot match anything, so this is the correct behavior.Three test cases added:
[""]single empty pattern → no match["", "some-string"]empty then valid → matches valid["", ""]all empty → no match