[GHSA-cv3v-7846-6pxm] Unauthorized File Access in node-git-server

[RainSignal]

Updates

• Affected products

Comments
The advisory states "All versions before 0.6.1" without specifying
a start version. Code review shows:

Version 0.1.0 does NOT contain the vulnerable code:
https://github.com/gabrielcsapo/node-git-server/tree/0.1.0
The lib/ directory in 0.1.0 only contains: basicAuth.js, handle.js,
info.js, no_cache.js, onexit.js, service.js. There is no git.js and
the Git class with the dirMap logic does not exist yet.

Version 0.2.0 DOES contain the vulnerable code:
https://github.com/gabrielcsapo/node-git-server/blob/0.2.0/lib/git.js

The constructor in 0.2.0 uses:
return path.resolve(repoDir, dir);

path.resolve() prioritizes the last absolute path argument, so if
an attacker passes a repository name starting with "/", the repoDir
is completely overridden:
path.resolve("/repos", "/etc") // returns /etc

Therefore the affected version range should start from 0.2.0,
not from "all versions".

[github-actions]

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the Keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot. Please see CONTRIBUTING.md for more policy details.

[advisory-database]

Hi @RainSignal! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!