C#/Java: Modelgenerator. Lift models to unbound generic implementations.#22192
Open
michaelnebel wants to merge 5 commits into
Open
C#/Java: Modelgenerator. Lift models to unbound generic implementations.#22192michaelnebel wants to merge 5 commits into
michaelnebel wants to merge 5 commits into
Conversation
michaelnebel
force-pushed
the
shared/modelgengeneric
branch
from
July 16, 2026 10:26
1756034 to
16766cc
Compare
michaelnebel
changed the title
michaelnebel
force-pushed
the
shared/modelgengeneric
branch
from
July 16, 2026 12:49
16766cc to
392d02d
Compare
michaelnebel
force-pushed
the
shared/modelgengeneric
branch
from
July 17, 2026 07:23
392d02d to
f184d28
Compare
michaelnebel
added
the
no-change-note-required
michaelnebel
marked this pull request as ready for review
July 17, 2026 08:51
Contributor
There was a problem hiding this comment.
Pull request overview
Updates C# and Java model generators to lift override models to unbound generic declarations.
Changes:
- Canonicalizes overridden generic callables.
- Adds direct and nested generic inheritance tests.
Show a summary per file
| File | Description |
|---|---|
java/ql/test/utils/modelgenerator/dataflow/p/Generics.java |
Adds Java generic override test cases. |
java/ql/src/utils/modelgenerator/internal/CaptureModels.qll |
Resolves overrides to source declarations. |
csharp/ql/test/utils/modelgenerator/dataflow/Summaries.cs |
Adds C# generic virtual override tests. |
csharp/ql/src/utils/modelgenerator/internal/CaptureModels.qll |
Resolves overridden callables to unbound declarations. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Medium
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we update the model generator to cater for lifting models to unbound declarations.
If the PR is review'ed on a commit basis, the effect for C# is evident.