Conversation
It's not possible to get from the API which user blocked you. This is great to prevent spam and abuses. It however makes it difficult to also detect early when an invite to an org is going to fail. At scale, this might mean that users see many invitation at once and decide to just block the user instead of refusing the invitations. In which case entitlements doesn't handle the resulting 422 and fails with ``` 'Octokit::Response::RaiseError#on_complete': PUT https://api.github.com/teams/<id>/memberships/<handle>: 422 - Validation Failed (Octokit::UnprocessableEntity) ``` This change hopes to ease this pain by warning but not failing on such cases. It would then be up to the owner of the orgs to verify which invitations went through.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not possible to get from the API which user blocked you. This is great to prevent spam and abuses. It however makes it difficult to also detect early when an invite to an org is going to fail.
At scale, this might mean that users see many invitation at once and decide to just block the user instead of refusing the invitations. In which case entitlements doesn't handle the resulting 422 and fails with
This change hopes to ease this pain by warning but not failing on such cases. It would then be up to the owner of the orgs to verify which invitations went through.