Handle unsupported issueFieldValues enrichment in search_issues#2897
Open
kerobbi wants to merge 1 commit into
Open
Handle unsupported issueFieldValues enrichment in search_issues#2897kerobbi wants to merge 1 commit into
kerobbi wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the search_issues tool’s custom-field enrichment to be best-effort so it no longer fails on GitHub Enterprise Server instances whose GraphQL schema does not support issueFieldValues (e.g., GHES 3.20.x). The search now returns REST results even when GraphQL enrichment is unavailable, aligning with the existing “best-effort enrichment” behavior in issue_read get.
Changes:
- Made
search_issuesGraphQL-basedfield_valuesenrichment non-fatal and record enrichment failures on the request context. - Ensured
search_issuesreturns REST hits withfield_valuesomitted when enrichment cannot be performed. - Added a unit test covering the unsupported-schema (
issueFieldValuesmissing) path.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/issues.go | Makes search_issues field-value enrichment best-effort (do not fail the search when enrichment fails). |
| pkg/github/issues_test.go | Adds coverage for the unsupported GraphQL schema scenario to ensure REST results still return. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Low
9qrv90-a11y
approved these changes
Jul 16, 2026
9qrv90-a11y
approved these changes
Jul 16, 2026
9qrv90-a11y
approved these changes
Jul 16, 2026
9qrv90-a11y
approved these changes
Jul 16, 2026
9qrv90-a11y
approved these changes
Jul 16, 2026
9qrv90-a11y
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the custom field value enrichment in
search_issuesbest-effort, so a search no longer fails when the server's GraphQL schema doesn't support theissueFieldValuesfield (e.g. GHES).Why
Fixes #2831
What changed
search_issuesreturns its REST hits (withfield_valuesomitted) when enrichment is unavailable, matching howissue_readgetalready treats the same enrichmentTest_SearchIssues_FieldValuesEnrichmentUnsupportedcovering the unsupported-schema pathMCP impact
search_issuesnow degrades gracefully instead of failing when field value enrichment is unsupportedSecurity / limits
Tool renaming
Lint & tests
./script/lint./script/testDocs