Minor tooling and docs fixes#36
Conversation
|
Thanks for the contribution, @pganguli ! @MitchellThompkins, I would appreciate if you could have a brief look at the first two commits related to the test environment. |
I left one comment but otherwise lgtm. I don't work on a SELinux machine so I didn't get bit by the One thing though @ttl-octave, do you want to merge this into |
|
@MitchellThompkins, thanks for reviewing! I totally agree to directly merge this into main. |
Hi, yeah, I work on Fedora, so I had to fix that issue before I could even run anything using the docker image. I also tested to see if adding |
|
I changed the base barnch to |
* Without :z, Docker leaves the bind-mounted repo with its host SELinux label (e.g. user_home_t), which containers cannot access under Enforcing mode, causing check-local to fail with "Permission denied" on Makefile * :z relabels the mount for shared access between host and container * no-op on hosts without SELinux enabled
* gnuoctave/octave container runs as root by default, so files it creates in the bind-mounted repo (e.g. loose objects from check-ci's git stash create/git archive) end up owned by root on the host, blocking further git operations for the actual user * pass HOST_UID/HOST_GID to compose.yaml's user: directive so the container writes files as the calling user instead
* Without a required check, running docker compose directly (bypassing make check-local) silently substitutes empty strings for HOST_UID/ HOST_GID, producing a bogus "user: :" that fails confusingly * :? makes docker compose fail fast with a clear error instead
Done! |
3 participants
compose.yaml: add the:zSELinux relabeling flag to the bind mount, sodevel/compose.yamlworks out of the box on SELinux-enforcing hosts (Fedora, RHEL, etc.) instead of silently hitting permission-denied errors.check-local: run the container as the host user instead of root, so files created duringmake check-localaren't root-owned on the host afterward.README.md: fix typos and trailing whitespace.No functional changes to pkg-control itself.